Compare commits

..
15 Commits
223 changed files with 2505 additions and 1429 deletions
+1 -1
View File
@@ -261,7 +261,7 @@ fail2ban-client status planka
### Import from Trello
It is not yet implemented inside Planka, but for now you can use the great tool [trello2planka](https://github.com/christophenne/trello2planka) to do the import.
It's already available in Planka, or you can also use the great tool [trello2planka](https://github.com/christophenne/trello2planka) to do the import.
## Development
+5
View File
@@ -1,4 +1,5 @@
import socket from './socket';
import http from './http';
import { transformCard } from './cards';
import { transformAttachment } from './attachments';
@@ -7,6 +8,9 @@ import { transformAttachment } from './attachments';
const createBoard = (projectId, data, headers) =>
socket.post(`/projects/${projectId}/boards`, data, headers);
const createBoardWithImport = (projectId, data, requestId, headers) =>
http.post(`/projects/${projectId}/boards?requestId=${requestId}`, data, headers);
const getBoard = (id, headers) =>
socket.get(`/boards/${id}`, undefined, headers).then((body) => ({
...body,
@@ -23,6 +27,7 @@ const deleteBoard = (id, headers) => socket.delete(`/boards/${id}`, undefined, h
export default {
createBoard,
createBoardWithImport,
getBoard,
updateBoard,
deleteBoard,
+6 -13
View File
@@ -35,18 +35,8 @@ export const transformCardData = (data) => ({
/* Actions */
const getCards = (boardId, data, headers) =>
socket.get(`/board/${boardId}/cards`, data, headers).then((body) => ({
...body,
items: body.items.map(transformCard),
included: {
...body.included,
attachments: body.included.attachments.map(transformAttachment),
},
}));
const createCard = (boardId, data, headers) =>
socket.post(`/boards/${boardId}/cards`, transformCardData(data), headers).then((body) => ({
const createCard = (listId, data, headers) =>
socket.post(`/lists/${listId}/cards`, transformCardData(data), headers).then((body) => ({
...body,
item: transformCard(body.item),
}));
@@ -55,6 +45,10 @@ const getCard = (id, headers) =>
socket.get(`/cards/${id}`, undefined, headers).then((body) => ({
...body,
item: transformCard(body.item),
included: {
...body.included,
attachments: body.included.attachments.map(transformAttachment),
},
}));
const updateCard = (id, data, headers) =>
@@ -83,7 +77,6 @@ const makeHandleCardUpdate = makeHandleCardCreate;
const makeHandleCardDelete = makeHandleCardCreate;
export default {
getCards,
createCard,
getCard,
updateCard,
@@ -10,11 +10,11 @@ import CardModalContainer from '../../containers/CardModalContainer';
import ListAdd from './ListAdd';
import { ReactComponent as PlusMathIcon } from '../../assets/images/plus-math-icon.svg';
import styles from './BoardKanban.module.scss';
import styles from './Board.module.scss';
const parseDndId = (dndId) => dndId.split(':')[1];
const BoardKanban = React.memo(
const Board = React.memo(
({ listIds, isCardModalOpened, canEdit, onListCreate, onListMove, onCardMove }) => {
const [t] = useTranslation();
const [isListAddOpened, setIsListAddOpened] = useState(false);
@@ -166,7 +166,7 @@ const BoardKanban = React.memo(
},
);
BoardKanban.propTypes = {
Board.propTypes = {
listIds: PropTypes.array.isRequired, // eslint-disable-line react/forbid-prop-types
isCardModalOpened: PropTypes.bool.isRequired,
canEdit: PropTypes.bool.isRequired,
@@ -175,4 +175,4 @@ BoardKanban.propTypes = {
onCardMove: PropTypes.func.isRequired,
};
export default BoardKanban;
export default Board;
@@ -72,7 +72,7 @@ const ListAdd = React.memo(({ onCreate, onClose }) => {
<Button
positive
content={t('action.addList')}
className={styles.submitButton}
className={styles.button}
onMouseOver={handleControlMouseOver}
onMouseOut={handleControlMouseOut}
/>
@@ -1,4 +1,9 @@
:global(#app) {
.button {
min-height: 30px;
vertical-align: top;
}
.controls {
margin-top: 4px;
}
@@ -18,11 +23,6 @@
}
}
.submitButton {
min-height: 30px;
vertical-align: top;
}
.wrapper {
background: #e2e4e6;
border-radius: 3px;
+3
View File
@@ -0,0 +1,3 @@
import Board from './Board';
export default Board;
@@ -1,3 +0,0 @@
import BoardKanban from './BoardKanban';
export default BoardKanban;
@@ -1,3 +1,4 @@
import { dequal } from 'dequal';
import omit from 'lodash/omit';
import React, { useCallback, useState } from 'react';
import PropTypes from 'prop-types';
@@ -10,7 +11,7 @@ import { BoardMembershipRoles } from '../../constants/Enums';
import styles from './BoardMembershipPermissionsSelectStep.module.scss';
const BoardMembershipPermissionsSelectStep = React.memo(
({ defaultData, title, buttonContent, onSelect, onBack }) => {
({ defaultData, title, buttonContent, onSelect, onBack, onClose }) => {
const [t] = useTranslation();
const [data, setData] = useState(() => ({
@@ -23,7 +24,7 @@ const BoardMembershipPermissionsSelectStep = React.memo(
setData((prevData) => ({
...prevData,
role,
canComment: role === BoardMembershipRoles.EDITOR ? null : !!prevData.canComment,
canComment: role === BoardMembershipRoles.VIEWER ? !!prevData.canComment : null,
}));
}, []);
@@ -35,8 +36,12 @@ const BoardMembershipPermissionsSelectStep = React.memo(
}, []);
const handleSubmit = useCallback(() => {
onSelect(data.role === BoardMembershipRoles.EDITOR ? omit(data, 'canComment') : data);
}, [onSelect, data]);
if (!dequal(data, defaultData)) {
onSelect(data.role === BoardMembershipRoles.VIEWER ? data : omit(data, 'canComment'));
}
onClose();
}, [defaultData, onSelect, onClose, data]);
return (
<>
@@ -65,7 +70,7 @@ const BoardMembershipPermissionsSelectStep = React.memo(
<div className={styles.menuItemDescription}>{t('common.canOnlyViewBoard')}</div>
</Menu.Item>
</Menu>
{data.role !== BoardMembershipRoles.EDITOR && (
{data.role === BoardMembershipRoles.VIEWER && (
<Segment basic className={styles.settings}>
<Radio
toggle
@@ -90,6 +95,7 @@ BoardMembershipPermissionsSelectStep.propTypes = {
buttonContent: PropTypes.string,
onSelect: PropTypes.func.isRequired,
onBack: PropTypes.func.isRequired,
onClose: PropTypes.func.isRequired,
};
BoardMembershipPermissionsSelectStep.defaultProps = {
@@ -43,7 +43,9 @@ const BoardMembershipsStep = React.memo(
);
useEffect(() => {
searchField.current.focus();
searchField.current.focus({
preventScroll: true,
});
}, []);
return (
@@ -1,7 +1,7 @@
:global(#app) {
.menu {
margin: 8px auto 0;
max-height: 320px;
max-height: 60vh;
overflow-x: hidden;
overflow-y: auto;
scrollbar-width: thin;
-25
View File
@@ -1,25 +0,0 @@
import React from 'react';
import PropTypes from 'prop-types';
import { Loader } from 'semantic-ui-react';
import { BoardTypes } from '../constants/Enums';
import BoardKanbanContainer from '../containers/BoardKanbanContainer';
const BoardWrapper = React.memo(({ type, isFetching }) => {
if (isFetching) {
return <Loader active />;
}
if (type === BoardTypes.KANBAN) {
return <BoardKanbanContainer />;
}
return null;
});
BoardWrapper.propTypes = {
type: PropTypes.string.isRequired,
isFetching: PropTypes.bool.isRequired,
};
export default BoardWrapper;
-70
View File
@@ -1,70 +0,0 @@
import React, { useCallback, useEffect, useRef } from 'react';
import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next';
import { Button, Form } from 'semantic-ui-react';
import { withPopup } from '../../lib/popup';
import { Input, Popup } from '../../lib/custom-ui';
import { useForm } from '../../hooks';
import styles from './AddPopup.module.scss';
const AddStep = React.memo(({ onCreate, onClose }) => {
const [t] = useTranslation();
const [data, handleFieldChange] = useForm({
name: '',
});
const nameField = useRef(null);
const handleSubmit = useCallback(() => {
const cleanData = {
...data,
type: 'kanban',
name: data.name.trim(),
};
if (!cleanData.name) {
nameField.current.select();
return;
}
onCreate(cleanData);
onClose();
}, [onCreate, onClose, data]);
useEffect(() => {
nameField.current.focus();
}, []);
return (
<>
<Popup.Header>
{t('common.createBoard', {
context: 'title',
})}
</Popup.Header>
<Popup.Content>
<Form onSubmit={handleSubmit}>
<Input
fluid
ref={nameField}
name="name"
value={data.name}
className={styles.field}
onChange={handleFieldChange}
/>
<Button positive content={t('action.createBoard')} />
</Form>
</Popup.Content>
</>
);
});
AddStep.propTypes = {
onCreate: PropTypes.func.isRequired,
onClose: PropTypes.func.isRequired,
};
export default withPopup(AddStep);
@@ -1,5 +0,0 @@
:global(#app) {
.field {
margin-bottom: 8px;
}
}
+117
View File
@@ -0,0 +1,117 @@
import React, { useCallback, useEffect, useRef } from 'react';
import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next';
import { Button, Form, Icon } from 'semantic-ui-react';
import { useDidUpdate, useToggle } from '../../../lib/hooks';
import { withPopup } from '../../../lib/popup';
import { Input, Popup } from '../../../lib/custom-ui';
import { useForm, useSteps } from '../../../hooks';
import ImportStep from './ImportStep';
import styles from './AddPopup.module.scss';
const StepTypes = {
IMPORT: 'IMPORT',
};
const AddStep = React.memo(({ onCreate, onClose }) => {
const [t] = useTranslation();
const [data, handleFieldChange, setData] = useForm({
name: '',
import: null,
});
const [step, openStep, handleBack] = useSteps();
const [focusNameFieldState, focusNameField] = useToggle();
const nameField = useRef(null);
const handleImportSelect = useCallback(
(nextImport) => {
setData((prevData) => ({
...prevData,
import: nextImport,
}));
},
[setData],
);
const handleImportBack = useCallback(() => {
handleBack();
focusNameField();
}, [handleBack, focusNameField]);
const handleSubmit = useCallback(() => {
const cleanData = {
...data,
name: data.name.trim(),
};
if (!cleanData.name) {
nameField.current.select();
return;
}
onCreate(cleanData);
onClose();
}, [onClose, data, onCreate]);
const handleImportClick = useCallback(() => {
openStep(StepTypes.IMPORT);
}, [openStep]);
useEffect(() => {
nameField.current.focus({
preventScroll: true,
});
}, []);
useDidUpdate(() => {
nameField.current.focus();
}, [focusNameFieldState]);
if (step && step.type === StepTypes.IMPORT) {
return <ImportStep onSelect={handleImportSelect} onBack={handleImportBack} />;
}
return (
<>
<Popup.Header>
{t('common.createBoard', {
context: 'title',
})}
</Popup.Header>
<Popup.Content>
<Form onSubmit={handleSubmit}>
<Input
fluid
ref={nameField}
name="name"
value={data.name}
className={styles.field}
onChange={handleFieldChange}
/>
<div className={styles.controls}>
<Button positive content={t('action.createBoard')} className={styles.createButton} />
<Button type="button" className={styles.importButton} onClick={handleImportClick}>
<Icon
name={data.import ? data.import.type : 'arrow down'}
className={styles.importButtonIcon}
/>
{data.import ? data.import.file.name : t('action.import')}
</Button>
</div>
</Form>
</Popup.Content>
</>
);
});
AddStep.propTypes = {
onCreate: PropTypes.func.isRequired,
onClose: PropTypes.func.isRequired,
};
export default withPopup(AddStep);
@@ -0,0 +1,42 @@
:global(#app) {
.controls {
display: flex;
max-width: 280px;
@media only screen and (max-width: 767px) {
max-width: 226px;
}
}
.createButton {
white-space: nowrap;
}
.field {
margin-bottom: 8px;
}
.importButton {
background: transparent;
box-shadow: none;
color: #6b808c;
font-weight: normal;
margin-left: auto;
margin-right: 0;
overflow: hidden;
text-align: left;
text-decoration: underline;
text-overflow: ellipsis;
transition: none;
white-space: nowrap;
&:hover {
background: rgba(9, 30, 66, 0.08);
color: #092d42;
}
}
.importButtonIcon {
text-decoration: none;
}
}
@@ -0,0 +1,51 @@
import React, { useCallback } from 'react';
import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next';
import { Button } from 'semantic-ui-react';
import { FilePicker, Popup } from '../../../lib/custom-ui';
import styles from './ImportStep.module.scss';
const ImportStep = React.memo(({ onSelect, onBack }) => {
const [t] = useTranslation();
const handleFileSelect = useCallback(
(type, file) => {
onSelect({
type,
file,
});
onBack();
},
[onSelect, onBack],
);
return (
<>
<Popup.Header onBack={onBack}>
{t('common.importBoard', {
context: 'title',
})}
</Popup.Header>
<Popup.Content>
<FilePicker onSelect={(file) => handleFileSelect('trello', file)} accept=".json">
<Button
fluid
type="button"
icon="trello"
content={t('common.fromTrello')}
className={styles.button}
/>
</FilePicker>
</Popup.Content>
</>
);
});
ImportStep.propTypes = {
onSelect: PropTypes.func.isRequired,
onBack: PropTypes.func.isRequired,
};
export default ImportStep;
@@ -0,0 +1,17 @@
:global(#app) {
.button {
background: transparent;
box-shadow: none;
color: #6b808c;
font-weight: normal;
margin-top: 8px;
padding: 6px 11px;
text-align: left;
transition: none;
&:hover {
background: rgba(9, 30, 66, 0.08);
color: #092d42;
}
}
}
@@ -0,0 +1,3 @@
import AddPopup from './AddPopup';
export default AddPopup;
@@ -29,7 +29,7 @@
}
.link {
color: #fff;
color: rgba(255, 255, 255, 0.72);
cursor: pointer;
display: block;
line-height: 20px;
@@ -60,6 +60,11 @@
&:hover {
background: rgba(0, 0, 0, 0.32);
}
.link {
color: #fff;
font-weight: bold;
}
}
.tabWrapper {
@@ -14,7 +14,6 @@ const Item = React.memo(({ type, data, createdAt, user }) => {
const [t] = useTranslation();
let contentNode;
switch (type) {
case ActivityTypes.CREATE_CARD:
contentNode = (
@@ -120,6 +120,7 @@ const Attachments = React.memo(
withCaption
withDownloadButton
options={{
wheelToZoom: true,
showHideAnimationType: 'none',
closeTitle: '',
zoomTitle: '',
@@ -9,6 +9,7 @@
text-align: left;
text-overflow: ellipsis;
transition: background 85ms ease;
white-space: nowrap;
&:hover {
background: #dfe3e6;
@@ -48,6 +48,7 @@
}
.taskCompleted {
color: #aaa;
text-decoration: line-through;
}
-41
View File
@@ -1,41 +0,0 @@
import React from 'react';
import PropTypes from 'prop-types';
import ModalTypes from '../constants/ModalTypes';
import FixedContainer from '../containers/FixedContainer';
import StaticContainer from '../containers/StaticContainer';
import UsersModalContainer from '../containers/UsersModalContainer';
import UserSettingsModalContainer from '../containers/UserSettingsModalContainer';
import ProjectAddModalContainer from '../containers/ProjectAddModalContainer';
import Background from './Background';
function Core({ currentModal, currentProject }) {
return (
<>
{currentProject && currentProject.background && (
<Background
type={currentProject.background.type}
name={currentProject.background.name}
imageUrl={currentProject.backgroundImage && currentProject.backgroundImage.url}
/>
)}
<FixedContainer />
<StaticContainer />
{currentModal === ModalTypes.USERS && <UsersModalContainer />}
{currentModal === ModalTypes.USER_SETTINGS && <UserSettingsModalContainer />}
{currentModal === ModalTypes.PROJECT_ADD && <ProjectAddModalContainer />}
</>
);
}
Core.propTypes = {
currentModal: PropTypes.oneOf(Object.values(ModalTypes)),
currentProject: PropTypes.object, // eslint-disable-line react/forbid-prop-types
};
Core.defaultProps = {
currentModal: undefined,
currentProject: undefined,
};
export default Core;
+69
View File
@@ -0,0 +1,69 @@
import React from 'react';
import PropTypes from 'prop-types';
import { useTranslation, Trans } from 'react-i18next';
import { Loader } from 'semantic-ui-react';
import ModalTypes from '../../constants/ModalTypes';
import FixedContainer from '../../containers/FixedContainer';
import StaticContainer from '../../containers/StaticContainer';
import UsersModalContainer from '../../containers/UsersModalContainer';
import UserSettingsModalContainer from '../../containers/UserSettingsModalContainer';
import ProjectAddModalContainer from '../../containers/ProjectAddModalContainer';
import Background from '../Background';
import styles from './Core.module.scss';
const Core = React.memo(
({ isInitializing, isSocketDisconnected, currentModal, currentProject }) => {
const [t] = useTranslation();
return (
<>
{isInitializing ? (
<Loader active size="massive" />
) : (
<>
{currentProject && currentProject.background && (
<Background
type={currentProject.background.type}
name={currentProject.background.name}
imageUrl={currentProject.backgroundImage && currentProject.backgroundImage.url}
/>
)}
<FixedContainer />
<StaticContainer />
{currentModal === ModalTypes.USERS && <UsersModalContainer />}
{currentModal === ModalTypes.USER_SETTINGS && <UserSettingsModalContainer />}
{currentModal === ModalTypes.PROJECT_ADD && <ProjectAddModalContainer />}
</>
)}
{isSocketDisconnected && (
<div className={styles.message}>
<div className={styles.messageHeader}>{t('common.noConnectionToServer')}</div>
<div className={styles.messageContent}>
<Trans i18nKey="common.allChangesWillBeAutomaticallySavedAfterConnectionRestored">
All changes will be automatically saved
<br />
after connection restored
</Trans>
</div>
</div>
)}
</>
);
},
);
Core.propTypes = {
isInitializing: PropTypes.bool.isRequired,
isSocketDisconnected: PropTypes.bool.isRequired,
currentModal: PropTypes.oneOf(Object.values(ModalTypes)),
currentProject: PropTypes.object, // eslint-disable-line react/forbid-prop-types
};
Core.defaultProps = {
currentModal: undefined,
currentProject: undefined,
};
export default Core;
+3
View File
@@ -0,0 +1,3 @@
import Core from './Core';
export default Core;
@@ -1,37 +0,0 @@
import React from 'react';
import PropTypes from 'prop-types';
import { useTranslation, Trans } from 'react-i18next';
import { Loader } from 'semantic-ui-react';
import CoreContainer from '../../containers/CoreContainer';
import styles from './CoreWrapper.module.scss';
const CoreWrapper = React.memo(({ isInitializing, isSocketDisconnected }) => {
const [t] = useTranslation();
return (
<>
{isInitializing ? <Loader active size="massive" /> : <CoreContainer />}
{isSocketDisconnected && (
<div className={styles.message}>
<div className={styles.messageHeader}>{t('common.noConnectionToServer')}</div>
<div className={styles.messageContent}>
<Trans i18nKey="common.allChangesWillBeAutomaticallySavedAfterConnectionRestored">
All changes will be automatically saved
<br />
after connection restored
</Trans>
</div>
</div>
)}
</>
);
});
CoreWrapper.propTypes = {
isInitializing: PropTypes.bool.isRequired,
isSocketDisconnected: PropTypes.bool.isRequired,
};
export default CoreWrapper;
@@ -1,3 +0,0 @@
import CoreWrapper from './CoreWrapper';
export default CoreWrapper;
@@ -89,7 +89,9 @@ const LabelsStep = React.memo(
);
useEffect(() => {
searchField.current.focus();
searchField.current.focus({
preventScroll: true,
});
}, []);
if (step) {
@@ -17,7 +17,7 @@
.items {
margin-top: 8px;
max-height: 320px;
max-height: 60vh;
overflow-x: hidden;
overflow-y: auto;
scrollbar-width: thin;
@@ -28,8 +28,8 @@ const ActionsStep = React.memo(
deleteConfirmationTitle,
deleteConfirmationContent,
deleteConfirmationButtonContent,
canLeave,
canEdit,
canLeave,
onUpdate,
onDelete,
onClose,
@@ -50,10 +50,8 @@ const ActionsStep = React.memo(
if (onUpdate) {
onUpdate(data);
}
onClose();
},
[onUpdate, onClose],
[onUpdate],
);
if (step) {
@@ -68,6 +66,7 @@ const ActionsStep = React.memo(
buttonContent="action.save"
onSelect={handleRoleSelect}
onBack={handleBack}
onClose={onClose}
/>
);
}
@@ -146,8 +145,8 @@ ActionsStep.propTypes = {
deleteConfirmationTitle: PropTypes.string,
deleteConfirmationContent: PropTypes.string,
deleteConfirmationButtonContent: PropTypes.string,
canLeave: PropTypes.bool.isRequired,
canEdit: PropTypes.bool.isRequired,
canLeave: PropTypes.bool.isRequired,
onUpdate: PropTypes.func,
onDelete: PropTypes.func.isRequired,
onClose: PropTypes.func.isRequired,
@@ -56,14 +56,14 @@ const AddStep = React.memo(
userId: step.params.userId,
...data,
});
onClose();
},
[onCreate, onClose, step],
[onCreate, step],
);
useEffect(() => {
searchField.current.focus();
searchField.current.focus({
preventScroll: true,
});
}, []);
if (step) {
@@ -79,6 +79,7 @@ const AddStep = React.memo(
buttonContent="action.addMember"
onSelect={handleRoleSelect}
onBack={handleBack}
onClose={onClose}
/>
);
}
@@ -1,7 +1,7 @@
:global(#app) {
.users {
margin-top: 8px;
max-height: 320px;
max-height: 60vh;
overflow-x: hidden;
overflow-y: auto;
scrollbar-width: thin;
@@ -44,8 +44,8 @@ const Memberships = React.memo(
deleteConfirmationTitle={deleteConfirmationTitle}
deleteConfirmationContent={deleteConfirmationContent}
deleteConfirmationButtonContent={deleteConfirmationButtonContent}
canLeave={items.length > 1 || canLeaveIfLast}
canEdit={canEdit}
canLeave={items.length > 1 || canLeaveIfLast}
onUpdate={(data) => onUpdate(item.id, data)}
onDelete={() => onDelete(item.id)}
>
+5 -5
View File
@@ -6,7 +6,7 @@ import { ReduxRouter } from '../lib/redux-router';
import Paths from '../constants/Paths';
import LoginContainer from '../containers/LoginContainer';
import CoreWrapperContainer from '../containers/CoreWrapperContainer';
import CoreContainer from '../containers/CoreContainer';
import NotFound from './NotFound';
import 'react-datepicker/dist/react-datepicker.css';
@@ -22,10 +22,10 @@ function Root({ store, history }) {
<ReduxRouter history={history}>
<Routes>
<Route path={Paths.LOGIN} element={<LoginContainer />} />
<Route path={Paths.ROOT} element={<CoreWrapperContainer />} />
<Route path={Paths.PROJECTS} element={<CoreWrapperContainer />} />
<Route path={Paths.BOARDS} element={<CoreWrapperContainer />} />
<Route path={Paths.CARDS} element={<CoreWrapperContainer />} />
<Route path={Paths.ROOT} element={<CoreContainer />} />
<Route path={Paths.PROJECTS} element={<CoreContainer />} />
<Route path={Paths.BOARDS} element={<CoreContainer />} />
<Route path={Paths.CARDS} element={<CoreContainer />} />
<Route path="*" element={<NotFound />} />
</Routes>
</ReduxRouter>
+24 -16
View File
@@ -2,19 +2,19 @@ import React from 'react';
import PropTypes from 'prop-types';
import classNames from 'classnames';
import { useTranslation, Trans } from 'react-i18next';
import { Icon } from 'semantic-ui-react';
import { Icon, Loader } from 'semantic-ui-react';
import ProjectsContainer from '../../containers/ProjectsContainer';
import BoardWrapperContainer from '../../containers/BoardWrapperContainer';
import BoardContainer from '../../containers/BoardContainer';
import styles from './Static.module.scss';
function Static({ cardId, boardId, projectId }) {
function Static({ projectId, cardId, board }) {
const [t] = useTranslation();
if (projectId === undefined) {
return (
<div className={styles.root}>
<div className={styles.wrapper}>
<ProjectsContainer />
</div>
);
@@ -22,7 +22,7 @@ function Static({ cardId, boardId, projectId }) {
if (cardId === null) {
return (
<div className={classNames(styles.root, styles.flex)}>
<div className={classNames(styles.wrapper, styles.wrapperFlex)}>
<div className={styles.message}>
<h1>
{t('common.cardNotFound', {
@@ -34,9 +34,9 @@ function Static({ cardId, boardId, projectId }) {
);
}
if (boardId === null) {
if (board === null) {
return (
<div className={classNames(styles.root, styles.flex)}>
<div className={classNames(styles.wrapper, styles.wrapperFlex)}>
<div className={styles.message}>
<h1>
{t('common.boardNotFound', {
@@ -50,7 +50,7 @@ function Static({ cardId, boardId, projectId }) {
if (projectId === null) {
return (
<div className={classNames(styles.root, styles.flex)}>
<div className={classNames(styles.wrapper, styles.wrapperFlex)}>
<div className={styles.message}>
<h1>
{t('common.projectNotFound', {
@@ -62,9 +62,9 @@ function Static({ cardId, boardId, projectId }) {
);
}
if (boardId === undefined) {
if (board === undefined) {
return (
<div className={classNames(styles.board, styles.flex)}>
<div className={classNames(styles.wrapper, styles.wrapperFlex, styles.wrapperProject)}>
<div className={styles.message}>
<Icon inverted name="hand point up outline" size="huge" className={styles.messageIcon} />
<h1 className={styles.messageTitle}>
@@ -80,23 +80,31 @@ function Static({ cardId, boardId, projectId }) {
);
}
if (board.isFetching) {
return (
<div className={classNames(styles.wrapper, styles.wrapperLoader, styles.wrapperProject)}>
<Loader active size="big" />
</div>
);
}
return (
<div className={classNames(styles.board, styles.flex)}>
<BoardWrapperContainer />
<div className={classNames(styles.wrapper, styles.wrapperFlex, styles.wrapperBoard)}>
<BoardContainer />
</div>
);
}
Static.propTypes = {
cardId: PropTypes.string,
boardId: PropTypes.string,
projectId: PropTypes.string,
cardId: PropTypes.string,
board: PropTypes.object, // eslint-disable-line react/forbid-prop-types
};
Static.defaultProps = {
cardId: undefined,
boardId: undefined,
projectId: undefined,
cardId: undefined,
board: undefined,
};
export default Static;
+18 -10
View File
@@ -1,13 +1,4 @@
:global(#app) {
.board {
margin-top: 174px;
}
.flex {
display: flex;
height: 100%;
}
.message {
align-content: space-between;
align-items: center;
@@ -34,7 +25,24 @@
text-align: center;
}
.root {
.wrapper {
height: 100%;
margin-top: 50px;
}
.wrapperBoard {
margin-top: 174px;
}
.wrapperFlex {
display: flex;
}
.wrapperLoader {
position: relative;
}
.wrapperProject {
margin-top: 98px;
}
}
@@ -88,7 +88,9 @@ const UserAddStep = React.memo(
}, [onCreate, data]);
useEffect(() => {
emailField.current.focus();
emailField.current.focus({
preventScroll: true,
});
}, []);
useEffect(() => {
@@ -1,4 +1,3 @@
import omit from 'lodash/omit';
import isEmail from 'validator/lib/isEmail';
import React, { useCallback, useEffect, useMemo, useRef } from 'react';
import PropTypes from 'prop-types';
@@ -78,16 +77,22 @@ const UserEmailEditStep = React.memo(
return;
}
if (usePasswordConfirmation && !cleanData.currentPassword) {
currentPasswordField.current.focus();
return;
if (usePasswordConfirmation) {
if (!cleanData.currentPassword) {
currentPasswordField.current.focus();
return;
}
} else {
delete cleanData.currentPassword;
}
onUpdate(usePasswordConfirmation ? cleanData : omit(cleanData, 'currentPassword'));
onUpdate(cleanData);
}, [email, usePasswordConfirmation, onUpdate, onClose, data]);
useEffect(() => {
emailField.current.focus();
emailField.current.focus({
preventScroll: true,
});
}, []);
useEffect(() => {
@@ -71,7 +71,9 @@ const UserPasswordEditStep = React.memo(
}, [usePasswordConfirmation, onUpdate, data]);
useEffect(() => {
passwordField.current.focus();
passwordField.current.focus({
preventScroll: true,
});
}, []);
useEffect(() => {
@@ -73,7 +73,9 @@ const UserSettingsModal = React.memo(
),
},
{
menuItem: 'About Planka',
menuItem: t('common.aboutPlanka', {
context: 'title',
}),
render: () => <AboutPane />,
},
];
@@ -1,4 +1,3 @@
import omit from 'lodash/omit';
import React, { useCallback, useEffect, useMemo, useRef } from 'react';
import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next';
@@ -78,16 +77,22 @@ const UserUsernameEditStep = React.memo(
return;
}
if (usePasswordConfirmation && !cleanData.currentPassword) {
currentPasswordField.current.focus();
return;
if (usePasswordConfirmation) {
if (!cleanData.currentPassword) {
currentPasswordField.current.focus();
return;
}
} else {
delete cleanData.currentPassword;
}
onUpdate(usePasswordConfirmation ? cleanData : omit(cleanData, 'currentPassword'));
onUpdate(cleanData);
}, [username, usePasswordConfirmation, onUpdate, onClose, data]);
useEffect(() => {
usernameField.current.focus();
usernameField.current.focus({
preventScroll: true,
});
}, []);
useEffect(() => {
-4
View File
@@ -3,10 +3,6 @@ export const ProjectBackgroundTypes = {
IMAGE: 'image',
};
export const BoardTypes = {
KANBAN: 'kanban',
};
export const BoardMembershipRoles = {
EDITOR: 'editor',
VIEWER: 'viewer',
@@ -15,13 +15,16 @@ const mapStateToProps = (state) => {
const filterLabels = selectors.selectFilterLabelsForCurrentBoard(state);
const currentUserMembership = selectors.selectCurrentUserMembershipForCurrentBoard(state);
const isCurrentUserEditor =
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR;
return {
memberships,
labels,
filterUsers,
filterLabels,
allUsers,
canEdit: !!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR,
canEdit: isCurrentUserEditor,
canEditMemberships: isCurrentUserManager,
};
};
@@ -4,17 +4,20 @@ import { connect } from 'react-redux';
import selectors from '../selectors';
import entryActions from '../entry-actions';
import { BoardMembershipRoles } from '../constants/Enums';
import BoardKanban from '../components/BoardKanban';
import Board from '../components/Board';
const mapStateToProps = (state) => {
const { cardId } = selectors.selectPath(state);
const currentUserMembership = selectors.selectCurrentUserMembershipForCurrentBoard(state);
const listIds = selectors.selectListIdsForCurrentBoard(state);
const isCurrentUserEditor =
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR;
return {
listIds,
isCardModalOpened: !!cardId,
canEdit: !!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR,
canEdit: isCurrentUserEditor,
};
};
@@ -28,4 +31,4 @@ const mapDispatchToProps = (dispatch) =>
dispatch,
);
export default connect(mapStateToProps, mapDispatchToProps)(BoardKanban);
export default connect(mapStateToProps, mapDispatchToProps)(Board);
@@ -1,15 +0,0 @@
import { connect } from 'react-redux';
import selectors from '../selectors';
import BoardWrapper from '../components/BoardWrapper';
const mapStateToProps = (state) => {
const { type, isFetching } = selectors.selectCurrentBoard(state);
return {
type,
isFetching,
};
};
export default connect(mapStateToProps)(BoardWrapper);
+4 -2
View File
@@ -30,6 +30,9 @@ const makeMapStateToProps = () => {
const tasks = selectTasksByCardId(state, id);
const notificationsTotal = selectNotificationsTotalByCardId(state, id);
const isCurrentUserEditor =
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR;
return {
id,
index,
@@ -48,8 +51,7 @@ const makeMapStateToProps = () => {
allProjectsToLists,
allBoardMemberships,
allLabels,
canEdit:
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR,
canEdit: isCurrentUserEditor,
};
};
};
+10 -5
View File
@@ -37,6 +37,14 @@ const mapStateToProps = (state) => {
const attachments = selectors.selectAttachmentsForCurrentCard(state);
const activities = selectors.selectActivitiesForCurrentCard(state);
let isCurrentUserEditor = false;
let isCurrentUserEditorOrCanComment = false;
if (currentUserMembership) {
isCurrentUserEditor = currentUserMembership.role === BoardMembershipRoles.EDITOR;
isCurrentUserEditorOrCanComment = isCurrentUserEditor || currentUserMembership.canComment;
}
return {
name,
description,
@@ -58,11 +66,8 @@ const mapStateToProps = (state) => {
allProjectsToLists,
allBoardMemberships,
allLabels,
canEdit: !!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR,
canEditCommentActivities:
!!currentUserMembership &&
(currentUserMembership.role === BoardMembershipRoles.EDITOR ||
currentUserMembership.canComment),
canEdit: isCurrentUserEditor,
canEditCommentActivities: isCurrentUserEditorOrCanComment,
canEditAllCommentActivities: isCurrentUserManager,
};
};
+4
View File
@@ -4,12 +4,16 @@ import selectors from '../selectors';
import Core from '../components/Core';
const mapStateToProps = (state) => {
const isCoreInitializing = selectors.selectIsCoreInitializing(state);
const isSocketDisconnected = selectors.selectIsSocketDisconnected(state);
const currentModal = selectors.selectCurrentModal(state);
const currentProject = selectors.selectCurrentProject(state);
return {
isSocketDisconnected,
currentModal,
currentProject,
isInitializing: isCoreInitializing,
};
};
@@ -1,15 +0,0 @@
import { connect } from 'react-redux';
import selectors from '../selectors';
import CoreWrapper from '../components/CoreWrapper';
const mapStateToProps = (state) => {
const isCoreInitializing = selectors.selectIsCoreInitializing(state);
return {
isInitializing: isCoreInitializing,
isSocketDisconnected: state.socket.isDisconnected,
};
};
export default connect(mapStateToProps)(CoreWrapper);
+4 -2
View File
@@ -15,14 +15,16 @@ const makeMapStateToProps = () => {
const cardIds = selectCardIdsByListId(state, id);
const currentUserMembership = selectors.selectCurrentUserMembershipForCurrentBoard(state);
const isCurrentUserEditor =
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR;
return {
id,
index,
name,
isPersisted,
cardIds,
canEdit:
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR,
canEdit: isCurrentUserEditor,
};
};
};
+4 -3
View File
@@ -4,12 +4,13 @@ import selectors from '../selectors';
import Static from '../components/Static';
const mapStateToProps = (state) => {
const { cardId, boardId, projectId } = selectors.selectPath(state);
const { cardId, projectId } = selectors.selectPath(state);
const currentBoard = selectors.selectCurrentBoard(state);
return {
cardId,
boardId,
projectId,
cardId,
board: currentBoard,
};
};
+2 -1
View File
@@ -7,10 +7,11 @@ const createBoardInCurrentProject = (data) => ({
},
});
const handleBoardCreate = (board) => ({
const handleBoardCreate = (board, requestId) => ({
type: EntryActionTypes.BOARD_CREATE_HANDLE,
payload: {
board,
requestId,
},
});
@@ -3,9 +3,10 @@ import { Input as SemanticUIInput } from 'semantic-ui-react';
import InputPassword from './InputPassword';
import InputMask from './InputMask';
const Input = SemanticUIInput;
export default class Input extends SemanticUIInput {
static Password = InputPassword;
Input.Password = InputPassword;
Input.Mask = InputMask;
static Mask = InputMask;
export default Input;
focus = (options) => this.inputRef.current.focus(options);
}
@@ -1,8 +1,8 @@
import InputMask from 'react-input-mask';
export default class MaskedInput extends InputMask {
focus() {
this.getInputDOMNode().focus();
focus(options) {
this.getInputDOMNode().focus(options);
}
select() {
+11 -2
View File
@@ -6,7 +6,7 @@ import { Button, Popup as SemanticUIPopup } from 'semantic-ui-react';
import styles from './Popup.module.css';
export default (WrappedComponent, defaultProps) => {
const Popup = React.memo(({ children, ...props }) => {
const Popup = React.memo(({ children, onClose, ...props }) => {
const [isOpened, setIsOpened] = useState(false);
const wrapper = useRef(null);
@@ -18,7 +18,11 @@ export default (WrappedComponent, defaultProps) => {
const handleClose = useCallback(() => {
setIsOpened(false);
}, []);
if (onClose) {
onClose();
}
}, [onClose]);
const handleMouseDown = useCallback((event) => {
event.stopPropagation();
@@ -105,6 +109,11 @@ export default (WrappedComponent, defaultProps) => {
Popup.propTypes = {
children: PropTypes.node.isRequired,
onClose: PropTypes.func,
};
Popup.defaultProps = {
onClose: undefined,
};
return Popup;
+4
View File
@@ -9,6 +9,7 @@ export default {
translation: {
common: {
aboutPlanka: 'About Planka',
account: 'Account',
actions: 'Actions',
addAttachment_title: 'Add Attachment',
@@ -92,8 +93,10 @@ export default {
filterByLabels_title: 'Filter By Labels',
filterByMembers_title: 'Filter By Members',
fromComputer_title: 'From Computer',
fromTrello: 'From Trello',
general: 'General',
hours: 'Hours',
importBoard_title: 'Import Board',
invalidCurrentPassword: 'Invalid current password',
labels: 'Labels',
language: 'Language',
@@ -201,6 +204,7 @@ export default {
editTitle_title: 'Edit Title',
editUsername_title: 'Edit Username',
hideDetails: 'Hide details',
import: 'Import',
leaveBoard: 'Leave board',
leaveProject: 'Leave project',
logOut_title: 'Log Out',
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm';
import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'Activity';
static fields = {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm';
import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'Attachment';
static fields = {
+6
View File
@@ -0,0 +1,6 @@
import { Model } from 'redux-orm';
export default class BaseModel extends Model {
// eslint-disable-next-line no-underscore-dangle, class-methods-use-this
_onDelete() {}
}
+12 -10
View File
@@ -1,13 +1,13 @@
import { Model, attr, fk, many } from 'redux-orm';
import { attr, fk, many } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'Board';
static fields = {
id: attr(),
type: attr(),
position: attr(),
name: attr(),
isFetching: attr({
@@ -125,11 +125,7 @@ export default class extends Model {
break;
case ActionTypes.BOARD_CREATE__SUCCESS:
Board.withId(payload.localId).delete();
Board.upsert({
...payload.board,
isFetching: false,
});
Board.upsert(payload.board);
break;
case ActionTypes.BOARD_FETCH__SUCCESS:
@@ -183,7 +179,7 @@ export default class extends Model {
return this.lists.orderBy('position');
}
getMembershipModel(userId) {
getMembershipModelForUser(userId) {
return this.memberships
.filter({
userId,
@@ -191,7 +187,7 @@ export default class extends Model {
.first();
}
hasMemberUser(userId) {
hasMembershipForUser(userId) {
return this.memberships
.filter({
userId,
@@ -199,6 +195,12 @@ export default class extends Model {
.exists();
}
isAvailableForUser(userId) {
return (
this.project && (this.project.hasManagerForUser(userId) || this.hasMembershipForUser(userId))
);
}
deleteRelated(exceptMemberUserId) {
this.memberships.toModelArray().forEach((boardMembershipModel) => {
if (boardMembershipModel.userId !== exceptMemberUserId) {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm';
import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'BoardMembership';
static fields = {
+38 -14
View File
@@ -1,10 +1,11 @@
import { Model, attr, fk, many, oneToOne } from 'redux-orm';
import { attr, fk, many, oneToOne } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
import Config from '../constants/Config';
import { ActivityTypes } from '../constants/Enums';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'Card';
static fields = {
@@ -74,7 +75,11 @@ export default class extends Model {
break;
case ActionTypes.SOCKET_RECONNECT_HANDLE:
Card.all().delete();
Card.all()
.toModelArray()
.forEach((cardModel) => {
cardModel.deleteWithClearable();
});
if (payload.cards) {
payload.cards.forEach((card) => {
@@ -176,7 +181,7 @@ export default class extends Model {
break;
case ActionTypes.CARD_DELETE:
Card.withId(payload.id).delete();
Card.withId(payload.id).deleteWithRelated();
break;
case ActionTypes.CARD_DELETE__SUCCESS:
@@ -220,15 +225,7 @@ export default class extends Model {
isActivitiesDetailsFetching: false,
});
cardModel.activities.toModelArray().forEach((activityModel) => {
if (activityModel.notification) {
activityModel.update({
isInCard: false,
});
} else {
activityModel.delete();
}
});
cardModel.deleteActivities();
break;
}
@@ -268,10 +265,37 @@ export default class extends Model {
});
}
isAvailableForUser(userId) {
return this.board && this.board.isAvailableForUser(userId);
}
deleteClearable() {
this.users.clear();
this.labels.clear();
}
deleteActivities() {
this.activities.toModelArray().forEach((activityModel) => {
if (activityModel.notification) {
activityModel.update({
isInCard: false,
});
} else {
activityModel.delete();
}
});
}
deleteRelated() {
this.deleteClearable();
this.tasks.delete();
this.attachments.delete();
this.activities.delete();
this.deleteActivities();
}
deleteWithClearable() {
this.deleteClearable();
this.delete();
}
deleteWithRelated() {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm';
import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'Label';
static fields = {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm';
import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'List';
static fields = {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk, oneToOne } from 'redux-orm';
import { attr, fk, oneToOne } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'Notification';
static fields = {
+15 -10
View File
@@ -1,9 +1,10 @@
import { Model, attr, many } from 'redux-orm';
import { attr, many } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
import { ProjectBackgroundTypes } from '../constants/Enums';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'Project';
static fields = {
@@ -143,21 +144,21 @@ export default class extends Model {
return this.boards.orderBy('position');
}
getOrderedMemberBoardsModelArray(userId) {
getOrderedBoardsModelArrayForUser(userId) {
return this.getOrderedBoardsQuerySet()
.toModelArray()
.filter((boardModel) => boardModel.hasMemberUser(userId));
.filter((boardModel) => boardModel.hasMembershipForUser(userId));
}
getOrderedAvailableBoardsModelArray(userId) {
if (this.hasManagerUser(userId)) {
getOrderedBoardsModelArrayAvailableForUser(userId) {
if (this.hasManagerForUser(userId)) {
return this.getOrderedBoardsQuerySet().toModelArray();
}
return this.getOrderedMemberBoardsModelArray(userId);
return this.getOrderedBoardsModelArrayForUser(userId);
}
hasManagerUser(userId) {
hasManagerForUser(userId) {
return this.managers
.filter({
userId,
@@ -165,8 +166,12 @@ export default class extends Model {
.exists();
}
hasMemberUserForAnyBoard(userId) {
return this.boards.toModelArray().some((boardModel) => boardModel.hasMemberUser(userId));
hasMembershipInAnyBoardForUser(userId) {
return this.boards.toModelArray().some((boardModel) => boardModel.hasMembershipForUser(userId));
}
isAvailableForUser(userId) {
return this.hasManagerForUser(userId) || this.hasMembershipInAnyBoardForUser(userId);
}
deleteRelated() {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm';
import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'ProjectManager';
static fields = {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm';
import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
export default class extends Model {
export default class extends BaseModel {
static modelName = 'Task';
static fields = {
+3 -2
View File
@@ -1,5 +1,6 @@
import { Model, attr } from 'redux-orm';
import { attr } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes';
const DEFAULT_EMAIL_UPDATE_FORM = {
@@ -29,7 +30,7 @@ const DEFAULT_USERNAME_UPDATE_FORM = {
error: null,
};
export default class extends Model {
export default class extends BaseModel {
static modelName = 'User';
static fields = {
+20 -4
View File
@@ -7,7 +7,7 @@ import actions from '../../../actions';
import api from '../../../api';
import { createLocalId } from '../../../utils/local-id';
export function* createBoard(projectId, data) {
export function* createBoard(projectId, { import: boardImport, ...data }) {
const nextData = {
...data,
position: yield select(selectors.selectNextBoardPosition, projectId),
@@ -30,7 +30,19 @@ export function* createBoard(projectId, data) {
({
item: board,
included: { boardMemberships },
} = yield call(request, api.createBoard, projectId, nextData));
} = yield boardImport
? call(
request,
api.createBoardWithImport,
projectId,
{
...nextData,
importType: boardImport.type,
importFile: boardImport.file,
},
localId,
)
: call(request, api.createBoard, projectId, nextData));
} catch (error) {
yield put(actions.createBoard.failure(localId, error));
return;
@@ -46,8 +58,12 @@ export function* createBoardInCurrentProject(data) {
yield call(createBoard, projectId, data);
}
export function* handleBoardCreate(board) {
yield put(actions.handleBoardCreate(board));
export function* handleBoardCreate(board, requestId) {
const isExists = yield select(selectors.selectIsBoardWithIdExists, requestId);
if (!isExists) {
yield put(actions.handleBoardCreate(board));
}
}
export function* fetchBoard(id) {
+4 -3
View File
@@ -12,7 +12,6 @@ export function* createCard(listId, data) {
const nextData = {
...data,
listId,
position: yield select(selectors.selectNextCardPosition, listId),
};
@@ -22,13 +21,14 @@ export function* createCard(listId, data) {
actions.createCard({
...nextData,
boardId,
listId,
id: localId,
}),
);
let card;
try {
({ item: card } = yield call(request, api.createCard, boardId, nextData));
({ item: card } = yield call(request, api.createCard, listId, nextData));
} catch (error) {
yield put(actions.createCard.failure(localId, error));
return;
@@ -61,8 +61,9 @@ export function* updateCurrentCard(data) {
yield call(updateCard, cardId, data);
}
// TODO: handle card transfer
export function* handleCardUpdate(card) {
yield put(actions.handleCardUpdate(card)); // TODO: handle card transfer
yield put(actions.handleCardUpdate(card));
}
export function* moveCard(id, listId, index) {
+6 -6
View File
@@ -39,8 +39,8 @@ export function* createListInCurrentBoard(data) {
yield call(createList, boardId, data);
}
export function* handleListCreate(label) {
yield put(actions.handleListCreate(label));
export function* handleListCreate(list) {
yield put(actions.handleListCreate(list));
}
export function* updateList(id, data) {
@@ -57,8 +57,8 @@ export function* updateList(id, data) {
yield put(actions.updateList.success(list));
}
export function* handleListUpdate(label) {
yield put(actions.handleListUpdate(label));
export function* handleListUpdate(list) {
yield put(actions.handleListUpdate(list));
}
export function* moveList(id, index) {
@@ -84,8 +84,8 @@ export function* deleteList(id) {
yield put(actions.deleteList.success(list));
}
export function* handleListDelete(label) {
yield put(actions.handleListDelete(label));
export function* handleListDelete(list) {
yield put(actions.handleListDelete(list));
}
export default {
@@ -24,6 +24,7 @@ export function* createProjectManager(projectId, data) {
({ item: projectManager } = yield call(request, api.createProjectManager, projectId, data));
} catch (error) {
yield put(actions.createProjectManager.failure(localId, error));
return;
}
yield put(actions.createProjectManager.success(localId, projectManager));
@@ -53,6 +53,7 @@ export function* updateProject(id, data) {
({ item: project } = yield call(request, api.updateProject, id, data));
} catch (error) {
yield put(actions.updateProject.failure(id, error));
return;
}
yield put(actions.updateProject.success(project));
@@ -76,6 +77,7 @@ export function* updateProjectBackgroundImage(id, data) {
({ item: project } = yield call(request, api.updateProjectBackgroundImage, id, data));
} catch (error) {
yield put(actions.updateProjectBackgroundImage.failure(id, error));
return;
}
yield put(actions.updateProjectBackgroundImage.success(project));
@@ -101,6 +103,7 @@ export function* deleteProject(id) {
({ item: project } = yield call(request, api.deleteProject, id));
} catch (error) {
yield put(actions.deleteProject.failure(id, error));
return;
}
yield put(actions.deleteProject.success(project));
+2 -2
View File
@@ -8,8 +8,8 @@ export default function* boardsWatchers() {
takeEvery(EntryActionTypes.BOARD_IN_CURRENT_PROJECT_CREATE, ({ payload: { data } }) =>
services.createBoardInCurrentProject(data),
),
takeEvery(EntryActionTypes.BOARD_CREATE_HANDLE, ({ payload: { board } }) =>
services.handleBoardCreate(board),
takeEvery(EntryActionTypes.BOARD_CREATE_HANDLE, ({ payload: { board, requestId } }) =>
services.handleBoardCreate(board, requestId),
),
takeEvery(EntryActionTypes.BOARD_FETCH, ({ payload: { id } }) => services.fetchBoard(id)),
takeEvery(EntryActionTypes.BOARD_UPDATE, ({ payload: { id, data } }) =>
+2 -2
View File
@@ -48,8 +48,8 @@ const createSocketEventsChannel = () =>
emit(entryActions.handleProjectManagerDelete(item));
};
const handleBoardCreate = ({ item }) => {
emit(entryActions.handleBoardCreate(item));
const handleBoardCreate = ({ item, requestId }) => {
emit(entryActions.handleBoardCreate(item, requestId));
};
const handleBoardUpdate = ({ item }) => {
+30 -23
View File
@@ -69,6 +69,31 @@ export const selectMembershipsForCurrentBoard = createSelector(
},
);
export const selectCurrentUserMembershipForCurrentBoard = createSelector(
orm,
(state) => selectPath(state).boardId,
(state) => selectCurrentUserId(state),
({ Board }, id, currentUserId) => {
if (!id) {
return id;
}
const boardModel = Board.withId(id);
if (!boardModel) {
return boardModel;
}
const boardMembershipModel = boardModel.getMembershipModelForUser(currentUserId);
if (!boardMembershipModel) {
return boardMembershipModel;
}
return boardMembershipModel.ref;
},
);
export const selectLabelsForCurrentBoard = createSelector(
orm,
(state) => selectPath(state).boardId,
@@ -147,29 +172,10 @@ export const selectFilterLabelsForCurrentBoard = createSelector(
},
);
export const selectCurrentUserMembershipForCurrentBoard = createSelector(
export const selectIsBoardWithIdExists = createSelector(
orm,
(state) => selectPath(state).boardId,
(state) => selectCurrentUserId(state),
({ Board }, id, currentUserId) => {
if (!id) {
return id;
}
const boardModel = Board.withId(id);
if (!boardModel) {
return boardModel;
}
const boardMembershipModel = boardModel.getMembershipModel(currentUserId);
if (!boardMembershipModel) {
return boardMembershipModel;
}
return boardMembershipModel.ref;
},
(_, id) => id,
({ Board }, id) => Board.idExists(id),
);
export default {
@@ -177,9 +183,10 @@ export default {
selectBoardById,
selectCurrentBoard,
selectMembershipsForCurrentBoard,
selectCurrentUserMembershipForCurrentBoard,
selectLabelsForCurrentBoard,
selectListIdsForCurrentBoard,
selectFilterUsersForCurrentBoard,
selectFilterLabelsForCurrentBoard,
selectCurrentUserMembershipForCurrentBoard,
selectIsBoardWithIdExists,
};
+2
View File
@@ -1,4 +1,5 @@
import router from './router';
import socket from './socket';
import core from './core';
import modals from './modals';
import users from './users';
@@ -13,6 +14,7 @@ import attachments from './attachments';
export default {
...router,
...socket,
...core,
...modals,
...users,
+7 -5
View File
@@ -67,10 +67,12 @@ export const selectBoardsForCurrentProject = createSelector(
return projectModel;
}
return projectModel.getOrderedAvailableBoardsModelArray(currentUserId).map((boardModel) => ({
...boardModel.ref,
isPersisted: !isLocalId(boardModel.id),
}));
return projectModel
.getOrderedBoardsModelArrayAvailableForUser(currentUserId)
.map((boardModel) => ({
...boardModel.ref,
isPersisted: !isLocalId(boardModel.id),
}));
},
);
@@ -89,7 +91,7 @@ export const selectIsCurrentUserManagerForCurrentProject = createSelector(
return false;
}
return projectModel.hasManagerUser(currentUserId);
return projectModel.hasManagerForUser(currentUserId);
},
);
+6 -36
View File
@@ -26,55 +26,35 @@ export const selectPath = createReduxOrmSelector(
case Paths.PROJECTS: {
const projectModel = Project.withId(pathsMatch.params.id);
if (!projectModel) {
if (!projectModel || !projectModel.isAvailableForUser(currentUserId)) {
return {
projectId: null,
};
}
if (!projectModel.hasManagerUser(currentUserId)) {
if (!projectModel.hasMemberUserForAnyBoard(currentUserId)) {
return {
projectId: null,
};
}
}
return {
projectId: projectModel.id,
};
}
case Paths.BOARDS: {
const boardModel = Board.withId(pathsMatch.params.id);
const projectModel = boardModel && boardModel.project;
if (!projectModel) {
if (!boardModel || !boardModel.isAvailableForUser(currentUserId)) {
return {
boardId: null,
projectId: null,
};
}
if (!projectModel.hasManagerUser(currentUserId)) {
if (!boardModel.hasMemberUser(currentUserId)) {
return {
boardId: null,
projectId: null,
};
}
}
return {
boardId: boardModel.id,
projectId: projectModel.id,
projectId: boardModel.projectId,
};
}
case Paths.CARDS: {
const cardModel = Card.withId(pathsMatch.params.id);
const boardModel = cardModel && cardModel.board;
const projectModel = boardModel && boardModel.project;
if (!projectModel) {
if (!cardModel || !cardModel.isAvailableForUser(currentUserId)) {
return {
cardId: null,
boardId: null,
@@ -82,20 +62,10 @@ export const selectPath = createReduxOrmSelector(
};
}
if (!projectModel.hasManagerUser(currentUserId)) {
if (!boardModel.hasMemberUser(currentUserId)) {
return {
cardId: null,
boardId: null,
projectId: null,
};
}
}
return {
cardId: cardModel.id,
boardId: boardModel.id,
projectId: projectModel.id,
boardId: cardModel.boardId,
projectId: cardModel.board.projectId,
};
}
default:
+5
View File
@@ -0,0 +1,5 @@
export const selectIsSocketDisconnected = ({ socket: { isDisconnected } }) => isDisconnected;
export default {
selectIsSocketDisconnected,
};
+2 -2
View File
@@ -52,7 +52,7 @@ export const selectProjectsForCurrentUser = createSelector(
}
return userModel.getOrderedAvailableProjectsModelArray().map((projectModel) => {
const boardsModels = projectModel.getOrderedAvailableBoardsModelArray(userModel.id);
const boardsModels = projectModel.getOrderedBoardsModelArrayAvailableForUser(userModel.id);
let notificationsTotal = 0;
boardsModels.forEach((boardModel) => {
@@ -86,7 +86,7 @@ export const selectProjectsToListsForCurrentUser = createSelector(
return userModel.getOrderedAvailableProjectsModelArray().map((projectModel) => ({
...projectModel.ref,
boards: projectModel.getOrderedMemberBoardsModelArray(id).map((boardModel) => ({
boards: projectModel.getOrderedBoardsModelArrayForUser(id).map((boardModel) => ({
...boardModel.ref,
lists: boardModel.getOrderedListsQuerySet().toRefArray(),
})),
+2 -2
View File
@@ -1,12 +1,12 @@
{
"name": "planka",
"version": "1.8.9",
"version": "1.9.2",
"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "planka",
"version": "1.8.9",
"version": "1.9.2",
"hasInstallScript": true,
"license": "MIT",
"dependencies": {
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "planka",
"version": "1.8.9",
"version": "1.9.2",
"private": true,
"homepage": "https://plankanban.github.io/planka",
"repository": {
@@ -12,16 +12,16 @@ const Errors = {
},
};
const emailOrUsernameValidator = (value) =>
value.includes('@')
? validator.isEmail(value)
: value.length >= 3 && value.length <= 16 && /^[a-zA-Z0-9]+((_|\.)?[a-zA-Z0-9])*$/.test(value);
module.exports = {
inputs: {
emailOrUsername: {
type: 'string',
custom: (value) =>
value.includes('@')
? validator.isEmail(value)
: value.length >= 3 &&
value.length <= 16 &&
/^[a-zA-Z0-9]+((_|\.)?[a-zA-Z0-9])*$/.test(value),
custom: emailOrUsernameValidator,
required: true,
},
password: {
+9 -7
View File
@@ -82,13 +82,15 @@ module.exports = {
const file = _.last(files);
const fileData = await sails.helpers.attachments.processUploadedFile(file);
const attachment = await sails.helpers.attachments.createOne(
fileData,
currentUser,
card,
inputs.requestId,
this.req,
);
const attachment = await sails.helpers.attachments.createOne.with({
values: {
...fileData,
card,
creatorUser: currentUser,
},
requestId: inputs.requestId,
request: this.req,
});
return exits.success({
item: attachment,
+6 -1
View File
@@ -48,7 +48,12 @@ module.exports = {
throw Errors.NOT_ENOUGH_RIGHTS;
}
attachment = await sails.helpers.attachments.deleteOne(attachment, board, card, this.req);
attachment = await sails.helpers.attachments.deleteOne.with({
board,
card,
record: attachment,
request: this.req,
});
if (!attachment) {
throw Errors.ATTACHMENT_NOT_FOUND;
@@ -50,7 +50,7 @@ module.exports = {
sails.config.custom.attachmentsPath,
attachment.dirname,
'thumbnails',
'cover-256.jpg',
`cover-256.${attachment.image.thumbnailsExtension}`,
);
if (!fs.existsSync(filePath)) {
+7 -1
View File
@@ -53,7 +53,13 @@ module.exports = {
}
const values = _.pick(inputs, ['name']);
attachment = await sails.helpers.attachments.updateOne(attachment, values, board, this.req);
attachment = await sails.helpers.attachments.updateOne.with({
values,
board,
record: attachment,
request: this.req,
});
if (!attachment) {
throw Errors.ATTACHMENT_NOT_FOUND;
@@ -68,8 +68,15 @@ module.exports = {
const values = _.pick(inputs, ['role', 'canComment']);
const boardMembership = await sails.helpers.boardMemberships
.createOne(values, user, board, this.req)
const boardMembership = await sails.helpers.boardMemberships.createOne
.with({
values: {
...values,
board,
user,
},
request: this.req,
})
.intercept('userAlreadyBoardMember', () => Errors.USER_ALREADY_BOARD_MEMBER);
return {
@@ -36,15 +36,15 @@ module.exports = {
);
if (!isProjectManager) {
throw Errors.BOARD_MEMBERSHIP_NOT_FOUND;
throw Errors.BOARD_MEMBERSHIP_NOT_FOUND; // Forbidden
}
}
boardMembership = await sails.helpers.boardMemberships.deleteOne(
boardMembership,
boardMembership = await sails.helpers.boardMemberships.deleteOne.with({
project,
this.req,
);
record: boardMembership,
request: this.req,
});
if (!boardMembership) {
throw Errors.BOARD_MEMBERSHIP_NOT_FOUND;
@@ -44,11 +44,11 @@ module.exports = {
const values = _.pick(inputs, ['role', 'canComment']);
boardMembership = await sails.helpers.boardMemberships.updateOne(
boardMembership,
boardMembership = await sails.helpers.boardMemberships.updateOne.with({
values,
this.req,
);
record: boardMembership,
request: this.req,
});
return {
item: boardMembership,
+64 -12
View File
@@ -1,7 +1,16 @@
const util = require('util');
const { v4: uuid } = require('uuid');
const Errors = {
PROJECT_NOT_FOUND: {
projectNotFound: 'Project not found',
},
NO_IMPORT_FILE_WAS_UPLOADED: {
noImportFileWasUploaded: 'No import file was uploaded',
},
INVALID_IMPORT_FILE: {
invalidImportFile: 'Invalid import file',
},
};
module.exports = {
@@ -11,11 +20,6 @@ module.exports = {
regex: /^[0-9]+$/,
required: true,
},
type: {
type: 'string',
isIn: Object.values(Board.Types),
required: true,
},
position: {
type: 'number',
required: true,
@@ -24,12 +28,26 @@ module.exports = {
type: 'string',
required: true,
},
importType: {
type: 'string',
isIn: Object.values(Board.ImportTypes),
},
requestId: {
type: 'string',
isNotEmptyString: true,
},
},
exits: {
projectNotFound: {
responseType: 'notFound',
},
noImportFileWasUploaded: {
responseType: 'unprocessableEntity',
},
uploadError: {
responseType: 'unprocessableEntity',
},
},
async fn(inputs) {
@@ -47,14 +65,48 @@ module.exports = {
throw Errors.PROJECT_NOT_FOUND; // Forbidden
}
const values = _.pick(inputs, ['type', 'position', 'name']);
const values = _.pick(inputs, ['position', 'name']);
const { board, boardMembership } = await sails.helpers.boards.createOne(
values,
currentUser,
project,
this.req,
);
let boardImport;
if (inputs.importType && Object.values(Board.ImportTypes).includes(inputs.importType)) {
const upload = util.promisify((options, callback) =>
this.req.file('importFile').upload(options, (error, files) => callback(error, files)),
);
let files;
try {
files = await upload({
saveAs: uuid(),
maxBytes: null,
});
} catch (error) {
return exits.uploadError(error.message); // TODO: add error
}
if (files.length === 0) {
throw Errors.NO_IMPORT_FILE_WAS_UPLOADED;
}
const file = _.last(files);
if (inputs.importType === Board.ImportTypes.TRELLO) {
boardImport = {
type: inputs.importType,
board: await sails.helpers.boards.processUploadedTrelloImportFile(file),
};
}
}
const { board, boardMembership } = await sails.helpers.boards.createOne.with({
values: {
...values,
project,
},
import: boardImport,
user: currentUser,
requestId: inputs.requestId,
request: this.req,
});
if (this.req.isSocket) {
sails.sockets.join(this.req, `board:${board.id}`); // TODO: only when subscription needed
+4 -1
View File
@@ -39,7 +39,10 @@ module.exports = {
throw Errors.BOARD_NOT_FOUND; // Forbidden
}
board = await sails.helpers.boards.deleteOne(board, this.req);
board = await sails.helpers.boards.deleteOne.with({
record: board,
request: this.req,
});
if (!board) {
throw Errors.BOARD_NOT_FOUND;
+3 -2
View File
@@ -47,7 +47,7 @@ module.exports = {
const labels = await sails.helpers.boards.getLabels(board.id);
const lists = await sails.helpers.boards.getLists(board.id);
const cards = await sails.helpers.boards.getCards(board);
const cards = await sails.helpers.boards.getCards(board.id);
const cardIds = sails.helpers.utils.mapRecords(cards);
const cardSubscriptions = await sails.helpers.cardSubscriptions.getMany({
@@ -69,7 +69,8 @@ module.exports = {
);
cards.forEach((card) => {
card.isSubscribed = isSubscribedByCardId[card.id] || false; // eslint-disable-line no-param-reassign
// eslint-disable-next-line no-param-reassign
card.isSubscribed = isSubscribedByCardId[card.id] || false;
});
if (this.req.isSocket) {
+6 -1
View File
@@ -47,7 +47,12 @@ module.exports = {
}
const values = _.pick(inputs, ['position', 'name']);
board = await sails.helpers.boards.updateOne(board, values, this.req);
board = await sails.helpers.boards.updateOne.with({
values,
record: board,
request: this.req,
});
if (!board) {
throw Errors.BOARD_NOT_FOUND;

Some files were not shown because too many files have changed in this diff Show More