Compare commits

..
20 Commits
Author SHA1 Message Date
Maksim Eltyshev 33765dfe8a chore: Update version 2022-12-26 22:56:13 +01:00
Maksim Eltyshev d21dee05a3 fix: Show completed tasks greyed out 2022-12-26 22:55:04 +01:00
Maksim Eltyshev 1dacd6e700 fix: Prevent scroll when focusing 2022-12-26 22:51:17 +01:00
Maksim Eltyshev 7e07a75124 fix: Improve quality of resized images 2022-12-26 22:43:21 +01:00
Maksim Eltyshev 6ffa817b53 ref: Remove board types, refactoring 2022-12-26 21:10:50 +01:00
Maksim Eltyshev 2b131f76c1 fix: Proper image error handling during migration 2022-12-24 16:24:50 +01:00
Maksim Eltyshev 2bc82d557a fix: Fix image size for animated attachments 2022-12-24 02:59:03 +01:00
Maksim Eltyshev 7c99aeb9e1 chore: Update version 2022-12-24 01:04:46 +01:00
Maksim Eltyshev 8d477af498 fix: Fix active tab style 2022-12-24 01:03:36 +01:00
Maksim Eltyshev 32507f2799 fix: Add missing translation key 2022-12-24 01:00:57 +01:00
Maksim Eltyshev 0a5210dd21 feat: Preserve original format of images, change interpolation kernel
Closes #349
2022-12-24 00:47:59 +01:00
Maksim Eltyshev b82a601f46 fix: Increase height of scroll area in popups 2022-12-21 22:57:04 +01:00
Maksim Eltyshev c658665ee8 meta: Update import from Trello 2022-12-17 00:09:43 +01:00
Maksim Eltyshev a37bad4867 chore: Update version 2022-12-16 23:55:19 +01:00
Christoph Enne 738ed19e7f feat: Trello board JSON import (#352)
Closes #27, closes #105
2022-12-17 03:48:06 +05:00
Maksim Eltyshev 9ce8b2ab9c chore: Update version 2022-12-16 17:06:35 +01:00
Maksim Eltyshev a8d312922a fix: Fix error on initial loading
Closes #347
2022-12-16 17:05:03 +01:00
Maksim Eltyshev 90c8b4d548 chore: Update version 2022-12-15 01:39:00 +01:00
Maksim Eltyshev 4941b51fa4 fix: Prevent popup from overflowing 2022-12-15 01:38:03 +01:00
Maksim Eltyshev a858419f3c fix: Fix router synchronization with redux store 2022-12-15 01:34:48 +01:00
240 changed files with 2673 additions and 1477 deletions
+1 -1
View File
@@ -261,7 +261,7 @@ fail2ban-client status planka
### Import from Trello ### Import from Trello
It is not yet implemented inside Planka, but for now you can use the great tool [trello2planka](https://github.com/christophenne/trello2planka) to do the import. It's already available in Planka, or you can also use the great tool [trello2planka](https://github.com/christophenne/trello2planka) to do the import.
## Development ## Development
-17
View File
@@ -32,13 +32,11 @@
"react-markdown": "^8.0.3", "react-markdown": "^8.0.3",
"react-photoswipe-gallery": "^2.2.2", "react-photoswipe-gallery": "^2.2.2",
"react-redux": "^8.0.5", "react-redux": "^8.0.5",
"react-router": "^6.4.3",
"react-router-dom": "^6.4.3", "react-router-dom": "^6.4.3",
"react-scripts": "5.0.1", "react-scripts": "5.0.1",
"react-simplemde-editor": "^5.2.0", "react-simplemde-editor": "^5.2.0",
"react-textarea-autosize": "^8.4.0", "react-textarea-autosize": "^8.4.0",
"redux": "^4.2.0", "redux": "^4.2.0",
"redux-first-history": "^5.1.1",
"redux-logger": "^3.0.6", "redux-logger": "^3.0.6",
"redux-orm": "^0.16.2", "redux-orm": "^0.16.2",
"redux-saga": "^1.2.1", "redux-saga": "^1.2.1",
@@ -19949,15 +19947,6 @@
"@babel/runtime": "^7.9.2" "@babel/runtime": "^7.9.2"
} }
}, },
"node_modules/redux-first-history": {
"version": "5.1.1",
"resolved": "https://registry.npmjs.org/redux-first-history/-/redux-first-history-5.1.1.tgz",
"integrity": "sha512-ujVHv+y9wC2rqavS5tLiSu6zkw+VYrEea+/ggwVTRuutadEtwxSRlaK19ry/PTLSQtFuUF1Xu+plL5erD4roVw==",
"peerDependencies": {
"history": "^4.7.2 || ^5.0",
"redux": "^3.6.0 || ^4.0.0"
}
},
"node_modules/redux-logger": { "node_modules/redux-logger": {
"version": "3.0.6", "version": "3.0.6",
"resolved": "https://registry.npmjs.org/redux-logger/-/redux-logger-3.0.6.tgz", "resolved": "https://registry.npmjs.org/redux-logger/-/redux-logger-3.0.6.tgz",
@@ -37850,12 +37839,6 @@
"@babel/runtime": "^7.9.2" "@babel/runtime": "^7.9.2"
} }
}, },
"redux-first-history": {
"version": "5.1.1",
"resolved": "https://registry.npmjs.org/redux-first-history/-/redux-first-history-5.1.1.tgz",
"integrity": "sha512-ujVHv+y9wC2rqavS5tLiSu6zkw+VYrEea+/ggwVTRuutadEtwxSRlaK19ry/PTLSQtFuUF1Xu+plL5erD4roVw==",
"requires": {}
},
"redux-logger": { "redux-logger": {
"version": "3.0.6", "version": "3.0.6",
"resolved": "https://registry.npmjs.org/redux-logger/-/redux-logger-3.0.6.tgz", "resolved": "https://registry.npmjs.org/redux-logger/-/redux-logger-3.0.6.tgz",
-2
View File
@@ -79,13 +79,11 @@
"react-markdown": "^8.0.3", "react-markdown": "^8.0.3",
"react-photoswipe-gallery": "^2.2.2", "react-photoswipe-gallery": "^2.2.2",
"react-redux": "^8.0.5", "react-redux": "^8.0.5",
"react-router": "^6.4.3",
"react-router-dom": "^6.4.3", "react-router-dom": "^6.4.3",
"react-scripts": "5.0.1", "react-scripts": "5.0.1",
"react-simplemde-editor": "^5.2.0", "react-simplemde-editor": "^5.2.0",
"react-textarea-autosize": "^8.4.0", "react-textarea-autosize": "^8.4.0",
"redux": "^4.2.0", "redux": "^4.2.0",
"redux-first-history": "^5.1.1",
"redux-logger": "^3.0.6", "redux-logger": "^3.0.6",
"redux-orm": "^0.16.2", "redux-orm": "^0.16.2",
"redux-saga": "^1.2.1", "redux-saga": "^1.2.1",
+5
View File
@@ -1,4 +1,5 @@
import socket from './socket'; import socket from './socket';
import http from './http';
import { transformCard } from './cards'; import { transformCard } from './cards';
import { transformAttachment } from './attachments'; import { transformAttachment } from './attachments';
@@ -7,6 +8,9 @@ import { transformAttachment } from './attachments';
const createBoard = (projectId, data, headers) => const createBoard = (projectId, data, headers) =>
socket.post(`/projects/${projectId}/boards`, data, headers); socket.post(`/projects/${projectId}/boards`, data, headers);
const createBoardWithImport = (projectId, data, requestId, headers) =>
http.post(`/projects/${projectId}/boards?requestId=${requestId}`, data, headers);
const getBoard = (id, headers) => const getBoard = (id, headers) =>
socket.get(`/boards/${id}`, undefined, headers).then((body) => ({ socket.get(`/boards/${id}`, undefined, headers).then((body) => ({
...body, ...body,
@@ -23,6 +27,7 @@ const deleteBoard = (id, headers) => socket.delete(`/boards/${id}`, undefined, h
export default { export default {
createBoard, createBoard,
createBoardWithImport,
getBoard, getBoard,
updateBoard, updateBoard,
deleteBoard, deleteBoard,
+6 -13
View File
@@ -35,18 +35,8 @@ export const transformCardData = (data) => ({
/* Actions */ /* Actions */
const getCards = (boardId, data, headers) => const createCard = (listId, data, headers) =>
socket.get(`/board/${boardId}/cards`, data, headers).then((body) => ({ socket.post(`/lists/${listId}/cards`, transformCardData(data), headers).then((body) => ({
...body,
items: body.items.map(transformCard),
included: {
...body.included,
attachments: body.included.attachments.map(transformAttachment),
},
}));
const createCard = (boardId, data, headers) =>
socket.post(`/boards/${boardId}/cards`, transformCardData(data), headers).then((body) => ({
...body, ...body,
item: transformCard(body.item), item: transformCard(body.item),
})); }));
@@ -55,6 +45,10 @@ const getCard = (id, headers) =>
socket.get(`/cards/${id}`, undefined, headers).then((body) => ({ socket.get(`/cards/${id}`, undefined, headers).then((body) => ({
...body, ...body,
item: transformCard(body.item), item: transformCard(body.item),
included: {
...body.included,
attachments: body.included.attachments.map(transformAttachment),
},
})); }));
const updateCard = (id, data, headers) => const updateCard = (id, data, headers) =>
@@ -83,7 +77,6 @@ const makeHandleCardUpdate = makeHandleCardCreate;
const makeHandleCardDelete = makeHandleCardCreate; const makeHandleCardDelete = makeHandleCardCreate;
export default { export default {
getCards,
createCard, createCard,
getCard, getCard,
updateCard, updateCard,
@@ -10,11 +10,11 @@ import CardModalContainer from '../../containers/CardModalContainer';
import ListAdd from './ListAdd'; import ListAdd from './ListAdd';
import { ReactComponent as PlusMathIcon } from '../../assets/images/plus-math-icon.svg'; import { ReactComponent as PlusMathIcon } from '../../assets/images/plus-math-icon.svg';
import styles from './BoardKanban.module.scss'; import styles from './Board.module.scss';
const parseDndId = (dndId) => dndId.split(':')[1]; const parseDndId = (dndId) => dndId.split(':')[1];
const BoardKanban = React.memo( const Board = React.memo(
({ listIds, isCardModalOpened, canEdit, onListCreate, onListMove, onCardMove }) => { ({ listIds, isCardModalOpened, canEdit, onListCreate, onListMove, onCardMove }) => {
const [t] = useTranslation(); const [t] = useTranslation();
const [isListAddOpened, setIsListAddOpened] = useState(false); const [isListAddOpened, setIsListAddOpened] = useState(false);
@@ -166,7 +166,7 @@ const BoardKanban = React.memo(
}, },
); );
BoardKanban.propTypes = { Board.propTypes = {
listIds: PropTypes.array.isRequired, // eslint-disable-line react/forbid-prop-types listIds: PropTypes.array.isRequired, // eslint-disable-line react/forbid-prop-types
isCardModalOpened: PropTypes.bool.isRequired, isCardModalOpened: PropTypes.bool.isRequired,
canEdit: PropTypes.bool.isRequired, canEdit: PropTypes.bool.isRequired,
@@ -175,4 +175,4 @@ BoardKanban.propTypes = {
onCardMove: PropTypes.func.isRequired, onCardMove: PropTypes.func.isRequired,
}; };
export default BoardKanban; export default Board;
@@ -72,7 +72,7 @@ const ListAdd = React.memo(({ onCreate, onClose }) => {
<Button <Button
positive positive
content={t('action.addList')} content={t('action.addList')}
className={styles.submitButton} className={styles.button}
onMouseOver={handleControlMouseOver} onMouseOver={handleControlMouseOver}
onMouseOut={handleControlMouseOut} onMouseOut={handleControlMouseOut}
/> />
@@ -1,4 +1,9 @@
:global(#app) { :global(#app) {
.button {
min-height: 30px;
vertical-align: top;
}
.controls { .controls {
margin-top: 4px; margin-top: 4px;
} }
@@ -18,11 +23,6 @@
} }
} }
.submitButton {
min-height: 30px;
vertical-align: top;
}
.wrapper { .wrapper {
background: #e2e4e6; background: #e2e4e6;
border-radius: 3px; border-radius: 3px;
+3
View File
@@ -0,0 +1,3 @@
import Board from './Board';
export default Board;
@@ -1,3 +0,0 @@
import BoardKanban from './BoardKanban';
export default BoardKanban;
@@ -1,3 +1,4 @@
import { dequal } from 'dequal';
import omit from 'lodash/omit'; import omit from 'lodash/omit';
import React, { useCallback, useState } from 'react'; import React, { useCallback, useState } from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
@@ -10,7 +11,7 @@ import { BoardMembershipRoles } from '../../constants/Enums';
import styles from './BoardMembershipPermissionsSelectStep.module.scss'; import styles from './BoardMembershipPermissionsSelectStep.module.scss';
const BoardMembershipPermissionsSelectStep = React.memo( const BoardMembershipPermissionsSelectStep = React.memo(
({ defaultData, title, buttonContent, onSelect, onBack }) => { ({ defaultData, title, buttonContent, onSelect, onBack, onClose }) => {
const [t] = useTranslation(); const [t] = useTranslation();
const [data, setData] = useState(() => ({ const [data, setData] = useState(() => ({
@@ -23,7 +24,7 @@ const BoardMembershipPermissionsSelectStep = React.memo(
setData((prevData) => ({ setData((prevData) => ({
...prevData, ...prevData,
role, role,
canComment: role === BoardMembershipRoles.EDITOR ? null : !!prevData.canComment, canComment: role === BoardMembershipRoles.VIEWER ? !!prevData.canComment : null,
})); }));
}, []); }, []);
@@ -35,8 +36,12 @@ const BoardMembershipPermissionsSelectStep = React.memo(
}, []); }, []);
const handleSubmit = useCallback(() => { const handleSubmit = useCallback(() => {
onSelect(data.role === BoardMembershipRoles.EDITOR ? omit(data, 'canComment') : data); if (!dequal(data, defaultData)) {
}, [onSelect, data]); onSelect(data.role === BoardMembershipRoles.VIEWER ? data : omit(data, 'canComment'));
}
onClose();
}, [defaultData, onSelect, onClose, data]);
return ( return (
<> <>
@@ -65,7 +70,7 @@ const BoardMembershipPermissionsSelectStep = React.memo(
<div className={styles.menuItemDescription}>{t('common.canOnlyViewBoard')}</div> <div className={styles.menuItemDescription}>{t('common.canOnlyViewBoard')}</div>
</Menu.Item> </Menu.Item>
</Menu> </Menu>
{data.role !== BoardMembershipRoles.EDITOR && ( {data.role === BoardMembershipRoles.VIEWER && (
<Segment basic className={styles.settings}> <Segment basic className={styles.settings}>
<Radio <Radio
toggle toggle
@@ -90,6 +95,7 @@ BoardMembershipPermissionsSelectStep.propTypes = {
buttonContent: PropTypes.string, buttonContent: PropTypes.string,
onSelect: PropTypes.func.isRequired, onSelect: PropTypes.func.isRequired,
onBack: PropTypes.func.isRequired, onBack: PropTypes.func.isRequired,
onClose: PropTypes.func.isRequired,
}; };
BoardMembershipPermissionsSelectStep.defaultProps = { BoardMembershipPermissionsSelectStep.defaultProps = {
@@ -43,7 +43,9 @@ const BoardMembershipsStep = React.memo(
); );
useEffect(() => { useEffect(() => {
searchField.current.focus(); searchField.current.focus({
preventScroll: true,
});
}, []); }, []);
return ( return (
@@ -1,7 +1,7 @@
:global(#app) { :global(#app) {
.menu { .menu {
margin: 8px auto 0; margin: 8px auto 0;
max-height: 320px; max-height: 60vh;
overflow-x: hidden; overflow-x: hidden;
overflow-y: auto; overflow-y: auto;
scrollbar-width: thin; scrollbar-width: thin;
-25
View File
@@ -1,25 +0,0 @@
import React from 'react';
import PropTypes from 'prop-types';
import { Loader } from 'semantic-ui-react';
import { BoardTypes } from '../constants/Enums';
import BoardKanbanContainer from '../containers/BoardKanbanContainer';
const BoardWrapper = React.memo(({ type, isFetching }) => {
if (isFetching) {
return <Loader active />;
}
if (type === BoardTypes.KANBAN) {
return <BoardKanbanContainer />;
}
return null;
});
BoardWrapper.propTypes = {
type: PropTypes.string.isRequired,
isFetching: PropTypes.bool.isRequired,
};
export default BoardWrapper;
-70
View File
@@ -1,70 +0,0 @@
import React, { useCallback, useEffect, useRef } from 'react';
import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next';
import { Button, Form } from 'semantic-ui-react';
import { withPopup } from '../../lib/popup';
import { Input, Popup } from '../../lib/custom-ui';
import { useForm } from '../../hooks';
import styles from './AddPopup.module.scss';
const AddStep = React.memo(({ onCreate, onClose }) => {
const [t] = useTranslation();
const [data, handleFieldChange] = useForm({
name: '',
});
const nameField = useRef(null);
const handleSubmit = useCallback(() => {
const cleanData = {
...data,
type: 'kanban',
name: data.name.trim(),
};
if (!cleanData.name) {
nameField.current.select();
return;
}
onCreate(cleanData);
onClose();
}, [onCreate, onClose, data]);
useEffect(() => {
nameField.current.focus();
}, []);
return (
<>
<Popup.Header>
{t('common.createBoard', {
context: 'title',
})}
</Popup.Header>
<Popup.Content>
<Form onSubmit={handleSubmit}>
<Input
fluid
ref={nameField}
name="name"
value={data.name}
className={styles.field}
onChange={handleFieldChange}
/>
<Button positive content={t('action.createBoard')} />
</Form>
</Popup.Content>
</>
);
});
AddStep.propTypes = {
onCreate: PropTypes.func.isRequired,
onClose: PropTypes.func.isRequired,
};
export default withPopup(AddStep);
@@ -1,5 +0,0 @@
:global(#app) {
.field {
margin-bottom: 8px;
}
}
+117
View File
@@ -0,0 +1,117 @@
import React, { useCallback, useEffect, useRef } from 'react';
import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next';
import { Button, Form, Icon } from 'semantic-ui-react';
import { useDidUpdate, useToggle } from '../../../lib/hooks';
import { withPopup } from '../../../lib/popup';
import { Input, Popup } from '../../../lib/custom-ui';
import { useForm, useSteps } from '../../../hooks';
import ImportStep from './ImportStep';
import styles from './AddPopup.module.scss';
const StepTypes = {
IMPORT: 'IMPORT',
};
const AddStep = React.memo(({ onCreate, onClose }) => {
const [t] = useTranslation();
const [data, handleFieldChange, setData] = useForm({
name: '',
import: null,
});
const [step, openStep, handleBack] = useSteps();
const [focusNameFieldState, focusNameField] = useToggle();
const nameField = useRef(null);
const handleImportSelect = useCallback(
(nextImport) => {
setData((prevData) => ({
...prevData,
import: nextImport,
}));
},
[setData],
);
const handleImportBack = useCallback(() => {
handleBack();
focusNameField();
}, [handleBack, focusNameField]);
const handleSubmit = useCallback(() => {
const cleanData = {
...data,
name: data.name.trim(),
};
if (!cleanData.name) {
nameField.current.select();
return;
}
onCreate(cleanData);
onClose();
}, [onClose, data, onCreate]);
const handleImportClick = useCallback(() => {
openStep(StepTypes.IMPORT);
}, [openStep]);
useEffect(() => {
nameField.current.focus({
preventScroll: true,
});
}, []);
useDidUpdate(() => {
nameField.current.focus();
}, [focusNameFieldState]);
if (step && step.type === StepTypes.IMPORT) {
return <ImportStep onSelect={handleImportSelect} onBack={handleImportBack} />;
}
return (
<>
<Popup.Header>
{t('common.createBoard', {
context: 'title',
})}
</Popup.Header>
<Popup.Content>
<Form onSubmit={handleSubmit}>
<Input
fluid
ref={nameField}
name="name"
value={data.name}
className={styles.field}
onChange={handleFieldChange}
/>
<div className={styles.controls}>
<Button positive content={t('action.createBoard')} className={styles.createButton} />
<Button type="button" className={styles.importButton} onClick={handleImportClick}>
<Icon
name={data.import ? data.import.type : 'arrow down'}
className={styles.importButtonIcon}
/>
{data.import ? data.import.file.name : t('action.import')}
</Button>
</div>
</Form>
</Popup.Content>
</>
);
});
AddStep.propTypes = {
onCreate: PropTypes.func.isRequired,
onClose: PropTypes.func.isRequired,
};
export default withPopup(AddStep);
@@ -0,0 +1,42 @@
:global(#app) {
.controls {
display: flex;
max-width: 280px;
@media only screen and (max-width: 767px) {
max-width: 226px;
}
}
.createButton {
white-space: nowrap;
}
.field {
margin-bottom: 8px;
}
.importButton {
background: transparent;
box-shadow: none;
color: #6b808c;
font-weight: normal;
margin-left: auto;
margin-right: 0;
overflow: hidden;
text-align: left;
text-decoration: underline;
text-overflow: ellipsis;
transition: none;
white-space: nowrap;
&:hover {
background: rgba(9, 30, 66, 0.08);
color: #092d42;
}
}
.importButtonIcon {
text-decoration: none;
}
}
@@ -0,0 +1,51 @@
import React, { useCallback } from 'react';
import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next';
import { Button } from 'semantic-ui-react';
import { FilePicker, Popup } from '../../../lib/custom-ui';
import styles from './ImportStep.module.scss';
const ImportStep = React.memo(({ onSelect, onBack }) => {
const [t] = useTranslation();
const handleFileSelect = useCallback(
(type, file) => {
onSelect({
type,
file,
});
onBack();
},
[onSelect, onBack],
);
return (
<>
<Popup.Header onBack={onBack}>
{t('common.importBoard', {
context: 'title',
})}
</Popup.Header>
<Popup.Content>
<FilePicker onSelect={(file) => handleFileSelect('trello', file)} accept=".json">
<Button
fluid
type="button"
icon="trello"
content={t('common.fromTrello')}
className={styles.button}
/>
</FilePicker>
</Popup.Content>
</>
);
});
ImportStep.propTypes = {
onSelect: PropTypes.func.isRequired,
onBack: PropTypes.func.isRequired,
};
export default ImportStep;
@@ -0,0 +1,17 @@
:global(#app) {
.button {
background: transparent;
box-shadow: none;
color: #6b808c;
font-weight: normal;
margin-top: 8px;
padding: 6px 11px;
text-align: left;
transition: none;
&:hover {
background: rgba(9, 30, 66, 0.08);
color: #092d42;
}
}
}
@@ -0,0 +1,3 @@
import AddPopup from './AddPopup';
export default AddPopup;
@@ -29,7 +29,7 @@
} }
.link { .link {
color: #fff; color: rgba(255, 255, 255, 0.72);
cursor: pointer; cursor: pointer;
display: block; display: block;
line-height: 20px; line-height: 20px;
@@ -60,6 +60,11 @@
&:hover { &:hover {
background: rgba(0, 0, 0, 0.32); background: rgba(0, 0, 0, 0.32);
} }
.link {
color: #fff;
font-weight: bold;
}
} }
.tabWrapper { .tabWrapper {
@@ -14,7 +14,6 @@ const Item = React.memo(({ type, data, createdAt, user }) => {
const [t] = useTranslation(); const [t] = useTranslation();
let contentNode; let contentNode;
switch (type) { switch (type) {
case ActivityTypes.CREATE_CARD: case ActivityTypes.CREATE_CARD:
contentNode = ( contentNode = (
@@ -120,6 +120,7 @@ const Attachments = React.memo(
withCaption withCaption
withDownloadButton withDownloadButton
options={{ options={{
wheelToZoom: true,
showHideAnimationType: 'none', showHideAnimationType: 'none',
closeTitle: '', closeTitle: '',
zoomTitle: '', zoomTitle: '',
@@ -9,6 +9,7 @@
text-align: left; text-align: left;
text-overflow: ellipsis; text-overflow: ellipsis;
transition: background 85ms ease; transition: background 85ms ease;
white-space: nowrap;
&:hover { &:hover {
background: #dfe3e6; background: #dfe3e6;
@@ -48,6 +48,7 @@
} }
.taskCompleted { .taskCompleted {
color: #aaa;
text-decoration: line-through; text-decoration: line-through;
} }
-41
View File
@@ -1,41 +0,0 @@
import React from 'react';
import PropTypes from 'prop-types';
import ModalTypes from '../constants/ModalTypes';
import FixedContainer from '../containers/FixedContainer';
import StaticContainer from '../containers/StaticContainer';
import UsersModalContainer from '../containers/UsersModalContainer';
import UserSettingsModalContainer from '../containers/UserSettingsModalContainer';
import ProjectAddModalContainer from '../containers/ProjectAddModalContainer';
import Background from './Background';
function Core({ currentModal, currentProject }) {
return (
<>
{currentProject && currentProject.background && (
<Background
type={currentProject.background.type}
name={currentProject.background.name}
imageUrl={currentProject.backgroundImage && currentProject.backgroundImage.url}
/>
)}
<FixedContainer />
<StaticContainer />
{currentModal === ModalTypes.USERS && <UsersModalContainer />}
{currentModal === ModalTypes.USER_SETTINGS && <UserSettingsModalContainer />}
{currentModal === ModalTypes.PROJECT_ADD && <ProjectAddModalContainer />}
</>
);
}
Core.propTypes = {
currentModal: PropTypes.oneOf(Object.values(ModalTypes)),
currentProject: PropTypes.object, // eslint-disable-line react/forbid-prop-types
};
Core.defaultProps = {
currentModal: undefined,
currentProject: undefined,
};
export default Core;
+69
View File
@@ -0,0 +1,69 @@
import React from 'react';
import PropTypes from 'prop-types';
import { useTranslation, Trans } from 'react-i18next';
import { Loader } from 'semantic-ui-react';
import ModalTypes from '../../constants/ModalTypes';
import FixedContainer from '../../containers/FixedContainer';
import StaticContainer from '../../containers/StaticContainer';
import UsersModalContainer from '../../containers/UsersModalContainer';
import UserSettingsModalContainer from '../../containers/UserSettingsModalContainer';
import ProjectAddModalContainer from '../../containers/ProjectAddModalContainer';
import Background from '../Background';
import styles from './Core.module.scss';
const Core = React.memo(
({ isInitializing, isSocketDisconnected, currentModal, currentProject }) => {
const [t] = useTranslation();
return (
<>
{isInitializing ? (
<Loader active size="massive" />
) : (
<>
{currentProject && currentProject.background && (
<Background
type={currentProject.background.type}
name={currentProject.background.name}
imageUrl={currentProject.backgroundImage && currentProject.backgroundImage.url}
/>
)}
<FixedContainer />
<StaticContainer />
{currentModal === ModalTypes.USERS && <UsersModalContainer />}
{currentModal === ModalTypes.USER_SETTINGS && <UserSettingsModalContainer />}
{currentModal === ModalTypes.PROJECT_ADD && <ProjectAddModalContainer />}
</>
)}
{isSocketDisconnected && (
<div className={styles.message}>
<div className={styles.messageHeader}>{t('common.noConnectionToServer')}</div>
<div className={styles.messageContent}>
<Trans i18nKey="common.allChangesWillBeAutomaticallySavedAfterConnectionRestored">
All changes will be automatically saved
<br />
after connection restored
</Trans>
</div>
</div>
)}
</>
);
},
);
Core.propTypes = {
isInitializing: PropTypes.bool.isRequired,
isSocketDisconnected: PropTypes.bool.isRequired,
currentModal: PropTypes.oneOf(Object.values(ModalTypes)),
currentProject: PropTypes.object, // eslint-disable-line react/forbid-prop-types
};
Core.defaultProps = {
currentModal: undefined,
currentProject: undefined,
};
export default Core;
+3
View File
@@ -0,0 +1,3 @@
import Core from './Core';
export default Core;
@@ -1,37 +0,0 @@
import React from 'react';
import PropTypes from 'prop-types';
import { useTranslation, Trans } from 'react-i18next';
import { Loader } from 'semantic-ui-react';
import CoreContainer from '../../containers/CoreContainer';
import styles from './CoreWrapper.module.scss';
const CoreWrapper = React.memo(({ isInitializing, isSocketDisconnected }) => {
const [t] = useTranslation();
return (
<>
{isInitializing ? <Loader active size="massive" /> : <CoreContainer />}
{isSocketDisconnected && (
<div className={styles.message}>
<div className={styles.messageHeader}>{t('common.noConnectionToServer')}</div>
<div className={styles.messageContent}>
<Trans i18nKey="common.allChangesWillBeAutomaticallySavedAfterConnectionRestored">
All changes will be automatically saved
<br />
after connection restored
</Trans>
</div>
</div>
)}
</>
);
});
CoreWrapper.propTypes = {
isInitializing: PropTypes.bool.isRequired,
isSocketDisconnected: PropTypes.bool.isRequired,
};
export default CoreWrapper;
@@ -1,3 +0,0 @@
import CoreWrapper from './CoreWrapper';
export default CoreWrapper;
@@ -89,7 +89,9 @@ const LabelsStep = React.memo(
); );
useEffect(() => { useEffect(() => {
searchField.current.focus(); searchField.current.focus({
preventScroll: true,
});
}, []); }, []);
if (step) { if (step) {
@@ -17,7 +17,7 @@
.items { .items {
margin-top: 8px; margin-top: 8px;
max-height: 320px; max-height: 60vh;
overflow-x: hidden; overflow-x: hidden;
overflow-y: auto; overflow-y: auto;
scrollbar-width: thin; scrollbar-width: thin;
@@ -28,8 +28,8 @@ const ActionsStep = React.memo(
deleteConfirmationTitle, deleteConfirmationTitle,
deleteConfirmationContent, deleteConfirmationContent,
deleteConfirmationButtonContent, deleteConfirmationButtonContent,
canLeave,
canEdit, canEdit,
canLeave,
onUpdate, onUpdate,
onDelete, onDelete,
onClose, onClose,
@@ -50,10 +50,8 @@ const ActionsStep = React.memo(
if (onUpdate) { if (onUpdate) {
onUpdate(data); onUpdate(data);
} }
onClose();
}, },
[onUpdate, onClose], [onUpdate],
); );
if (step) { if (step) {
@@ -68,6 +66,7 @@ const ActionsStep = React.memo(
buttonContent="action.save" buttonContent="action.save"
onSelect={handleRoleSelect} onSelect={handleRoleSelect}
onBack={handleBack} onBack={handleBack}
onClose={onClose}
/> />
); );
} }
@@ -146,8 +145,8 @@ ActionsStep.propTypes = {
deleteConfirmationTitle: PropTypes.string, deleteConfirmationTitle: PropTypes.string,
deleteConfirmationContent: PropTypes.string, deleteConfirmationContent: PropTypes.string,
deleteConfirmationButtonContent: PropTypes.string, deleteConfirmationButtonContent: PropTypes.string,
canLeave: PropTypes.bool.isRequired,
canEdit: PropTypes.bool.isRequired, canEdit: PropTypes.bool.isRequired,
canLeave: PropTypes.bool.isRequired,
onUpdate: PropTypes.func, onUpdate: PropTypes.func,
onDelete: PropTypes.func.isRequired, onDelete: PropTypes.func.isRequired,
onClose: PropTypes.func.isRequired, onClose: PropTypes.func.isRequired,
@@ -56,14 +56,14 @@ const AddStep = React.memo(
userId: step.params.userId, userId: step.params.userId,
...data, ...data,
}); });
onClose();
}, },
[onCreate, onClose, step], [onCreate, step],
); );
useEffect(() => { useEffect(() => {
searchField.current.focus(); searchField.current.focus({
preventScroll: true,
});
}, []); }, []);
if (step) { if (step) {
@@ -79,6 +79,7 @@ const AddStep = React.memo(
buttonContent="action.addMember" buttonContent="action.addMember"
onSelect={handleRoleSelect} onSelect={handleRoleSelect}
onBack={handleBack} onBack={handleBack}
onClose={onClose}
/> />
); );
} }
@@ -1,7 +1,7 @@
:global(#app) { :global(#app) {
.users { .users {
margin-top: 8px; margin-top: 8px;
max-height: 320px; max-height: 60vh;
overflow-x: hidden; overflow-x: hidden;
overflow-y: auto; overflow-y: auto;
scrollbar-width: thin; scrollbar-width: thin;
@@ -44,8 +44,8 @@ const Memberships = React.memo(
deleteConfirmationTitle={deleteConfirmationTitle} deleteConfirmationTitle={deleteConfirmationTitle}
deleteConfirmationContent={deleteConfirmationContent} deleteConfirmationContent={deleteConfirmationContent}
deleteConfirmationButtonContent={deleteConfirmationButtonContent} deleteConfirmationButtonContent={deleteConfirmationButtonContent}
canLeave={items.length > 1 || canLeaveIfLast}
canEdit={canEdit} canEdit={canEdit}
canLeave={items.length > 1 || canLeaveIfLast}
onUpdate={(data) => onUpdate(item.id, data)} onUpdate={(data) => onUpdate(item.id, data)}
onDelete={() => onDelete(item.id)} onDelete={() => onDelete(item.id)}
> >
+8 -8
View File
@@ -2,11 +2,11 @@ import React from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import { Provider } from 'react-redux'; import { Provider } from 'react-redux';
import { Route, Routes } from 'react-router-dom'; import { Route, Routes } from 'react-router-dom';
import { HistoryRouter as Router } from 'redux-first-history/rr6'; import { ReduxRouter } from '../lib/redux-router';
import Paths from '../constants/Paths'; import Paths from '../constants/Paths';
import LoginContainer from '../containers/LoginContainer'; import LoginContainer from '../containers/LoginContainer';
import CoreWrapperContainer from '../containers/CoreWrapperContainer'; import CoreContainer from '../containers/CoreContainer';
import NotFound from './NotFound'; import NotFound from './NotFound';
import 'react-datepicker/dist/react-datepicker.css'; import 'react-datepicker/dist/react-datepicker.css';
@@ -19,16 +19,16 @@ import '../styles.module.scss';
function Root({ store, history }) { function Root({ store, history }) {
return ( return (
<Provider store={store}> <Provider store={store}>
<Router history={history}> <ReduxRouter history={history}>
<Routes> <Routes>
<Route path={Paths.LOGIN} element={<LoginContainer />} /> <Route path={Paths.LOGIN} element={<LoginContainer />} />
<Route path={Paths.ROOT} element={<CoreWrapperContainer />} /> <Route path={Paths.ROOT} element={<CoreContainer />} />
<Route path={Paths.PROJECTS} element={<CoreWrapperContainer />} /> <Route path={Paths.PROJECTS} element={<CoreContainer />} />
<Route path={Paths.BOARDS} element={<CoreWrapperContainer />} /> <Route path={Paths.BOARDS} element={<CoreContainer />} />
<Route path={Paths.CARDS} element={<CoreWrapperContainer />} /> <Route path={Paths.CARDS} element={<CoreContainer />} />
<Route path="*" element={<NotFound />} /> <Route path="*" element={<NotFound />} />
</Routes> </Routes>
</Router> </ReduxRouter>
</Provider> </Provider>
); );
} }
+24 -16
View File
@@ -2,19 +2,19 @@ import React from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import classNames from 'classnames'; import classNames from 'classnames';
import { useTranslation, Trans } from 'react-i18next'; import { useTranslation, Trans } from 'react-i18next';
import { Icon } from 'semantic-ui-react'; import { Icon, Loader } from 'semantic-ui-react';
import ProjectsContainer from '../../containers/ProjectsContainer'; import ProjectsContainer from '../../containers/ProjectsContainer';
import BoardWrapperContainer from '../../containers/BoardWrapperContainer'; import BoardContainer from '../../containers/BoardContainer';
import styles from './Static.module.scss'; import styles from './Static.module.scss';
function Static({ cardId, boardId, projectId }) { function Static({ projectId, cardId, board }) {
const [t] = useTranslation(); const [t] = useTranslation();
if (projectId === undefined) { if (projectId === undefined) {
return ( return (
<div className={styles.root}> <div className={styles.wrapper}>
<ProjectsContainer /> <ProjectsContainer />
</div> </div>
); );
@@ -22,7 +22,7 @@ function Static({ cardId, boardId, projectId }) {
if (cardId === null) { if (cardId === null) {
return ( return (
<div className={classNames(styles.root, styles.flex)}> <div className={classNames(styles.wrapper, styles.wrapperFlex)}>
<div className={styles.message}> <div className={styles.message}>
<h1> <h1>
{t('common.cardNotFound', { {t('common.cardNotFound', {
@@ -34,9 +34,9 @@ function Static({ cardId, boardId, projectId }) {
); );
} }
if (boardId === null) { if (board === null) {
return ( return (
<div className={classNames(styles.root, styles.flex)}> <div className={classNames(styles.wrapper, styles.wrapperFlex)}>
<div className={styles.message}> <div className={styles.message}>
<h1> <h1>
{t('common.boardNotFound', { {t('common.boardNotFound', {
@@ -50,7 +50,7 @@ function Static({ cardId, boardId, projectId }) {
if (projectId === null) { if (projectId === null) {
return ( return (
<div className={classNames(styles.root, styles.flex)}> <div className={classNames(styles.wrapper, styles.wrapperFlex)}>
<div className={styles.message}> <div className={styles.message}>
<h1> <h1>
{t('common.projectNotFound', { {t('common.projectNotFound', {
@@ -62,9 +62,9 @@ function Static({ cardId, boardId, projectId }) {
); );
} }
if (boardId === undefined) { if (board === undefined) {
return ( return (
<div className={classNames(styles.board, styles.flex)}> <div className={classNames(styles.wrapper, styles.wrapperFlex, styles.wrapperProject)}>
<div className={styles.message}> <div className={styles.message}>
<Icon inverted name="hand point up outline" size="huge" className={styles.messageIcon} /> <Icon inverted name="hand point up outline" size="huge" className={styles.messageIcon} />
<h1 className={styles.messageTitle}> <h1 className={styles.messageTitle}>
@@ -80,23 +80,31 @@ function Static({ cardId, boardId, projectId }) {
); );
} }
if (board.isFetching) {
return (
<div className={classNames(styles.wrapper, styles.wrapperLoader, styles.wrapperProject)}>
<Loader active size="big" />
</div>
);
}
return ( return (
<div className={classNames(styles.board, styles.flex)}> <div className={classNames(styles.wrapper, styles.wrapperFlex, styles.wrapperBoard)}>
<BoardWrapperContainer /> <BoardContainer />
</div> </div>
); );
} }
Static.propTypes = { Static.propTypes = {
cardId: PropTypes.string,
boardId: PropTypes.string,
projectId: PropTypes.string, projectId: PropTypes.string,
cardId: PropTypes.string,
board: PropTypes.object, // eslint-disable-line react/forbid-prop-types
}; };
Static.defaultProps = { Static.defaultProps = {
cardId: undefined,
boardId: undefined,
projectId: undefined, projectId: undefined,
cardId: undefined,
board: undefined,
}; };
export default Static; export default Static;
+18 -10
View File
@@ -1,13 +1,4 @@
:global(#app) { :global(#app) {
.board {
margin-top: 174px;
}
.flex {
display: flex;
height: 100%;
}
.message { .message {
align-content: space-between; align-content: space-between;
align-items: center; align-items: center;
@@ -34,7 +25,24 @@
text-align: center; text-align: center;
} }
.root { .wrapper {
height: 100%;
margin-top: 50px; margin-top: 50px;
} }
.wrapperBoard {
margin-top: 174px;
}
.wrapperFlex {
display: flex;
}
.wrapperLoader {
position: relative;
}
.wrapperProject {
margin-top: 98px;
}
} }
@@ -88,7 +88,9 @@ const UserAddStep = React.memo(
}, [onCreate, data]); }, [onCreate, data]);
useEffect(() => { useEffect(() => {
emailField.current.focus(); emailField.current.focus({
preventScroll: true,
});
}, []); }, []);
useEffect(() => { useEffect(() => {
@@ -1,4 +1,3 @@
import omit from 'lodash/omit';
import isEmail from 'validator/lib/isEmail'; import isEmail from 'validator/lib/isEmail';
import React, { useCallback, useEffect, useMemo, useRef } from 'react'; import React, { useCallback, useEffect, useMemo, useRef } from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
@@ -78,16 +77,22 @@ const UserEmailEditStep = React.memo(
return; return;
} }
if (usePasswordConfirmation && !cleanData.currentPassword) { if (usePasswordConfirmation) {
currentPasswordField.current.focus(); if (!cleanData.currentPassword) {
return; currentPasswordField.current.focus();
return;
}
} else {
delete cleanData.currentPassword;
} }
onUpdate(usePasswordConfirmation ? cleanData : omit(cleanData, 'currentPassword')); onUpdate(cleanData);
}, [email, usePasswordConfirmation, onUpdate, onClose, data]); }, [email, usePasswordConfirmation, onUpdate, onClose, data]);
useEffect(() => { useEffect(() => {
emailField.current.focus(); emailField.current.focus({
preventScroll: true,
});
}, []); }, []);
useEffect(() => { useEffect(() => {
@@ -71,7 +71,9 @@ const UserPasswordEditStep = React.memo(
}, [usePasswordConfirmation, onUpdate, data]); }, [usePasswordConfirmation, onUpdate, data]);
useEffect(() => { useEffect(() => {
passwordField.current.focus(); passwordField.current.focus({
preventScroll: true,
});
}, []); }, []);
useEffect(() => { useEffect(() => {
@@ -73,7 +73,9 @@ const UserSettingsModal = React.memo(
), ),
}, },
{ {
menuItem: 'About Planka', menuItem: t('common.aboutPlanka', {
context: 'title',
}),
render: () => <AboutPane />, render: () => <AboutPane />,
}, },
]; ];
@@ -1,4 +1,3 @@
import omit from 'lodash/omit';
import React, { useCallback, useEffect, useMemo, useRef } from 'react'; import React, { useCallback, useEffect, useMemo, useRef } from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next'; import { useTranslation } from 'react-i18next';
@@ -78,16 +77,22 @@ const UserUsernameEditStep = React.memo(
return; return;
} }
if (usePasswordConfirmation && !cleanData.currentPassword) { if (usePasswordConfirmation) {
currentPasswordField.current.focus(); if (!cleanData.currentPassword) {
return; currentPasswordField.current.focus();
return;
}
} else {
delete cleanData.currentPassword;
} }
onUpdate(usePasswordConfirmation ? cleanData : omit(cleanData, 'currentPassword')); onUpdate(cleanData);
}, [username, usePasswordConfirmation, onUpdate, onClose, data]); }, [username, usePasswordConfirmation, onUpdate, onClose, data]);
useEffect(() => { useEffect(() => {
usernameField.current.focus(); usernameField.current.focus({
preventScroll: true,
});
}, []); }, []);
useEffect(() => { useEffect(() => {
-4
View File
@@ -3,10 +3,6 @@ export const ProjectBackgroundTypes = {
IMAGE: 'image', IMAGE: 'image',
}; };
export const BoardTypes = {
KANBAN: 'kanban',
};
export const BoardMembershipRoles = { export const BoardMembershipRoles = {
EDITOR: 'editor', EDITOR: 'editor',
VIEWER: 'viewer', VIEWER: 'viewer',
@@ -15,13 +15,16 @@ const mapStateToProps = (state) => {
const filterLabels = selectors.selectFilterLabelsForCurrentBoard(state); const filterLabels = selectors.selectFilterLabelsForCurrentBoard(state);
const currentUserMembership = selectors.selectCurrentUserMembershipForCurrentBoard(state); const currentUserMembership = selectors.selectCurrentUserMembershipForCurrentBoard(state);
const isCurrentUserEditor =
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR;
return { return {
memberships, memberships,
labels, labels,
filterUsers, filterUsers,
filterLabels, filterLabels,
allUsers, allUsers,
canEdit: !!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR, canEdit: isCurrentUserEditor,
canEditMemberships: isCurrentUserManager, canEditMemberships: isCurrentUserManager,
}; };
}; };
@@ -4,17 +4,20 @@ import { connect } from 'react-redux';
import selectors from '../selectors'; import selectors from '../selectors';
import entryActions from '../entry-actions'; import entryActions from '../entry-actions';
import { BoardMembershipRoles } from '../constants/Enums'; import { BoardMembershipRoles } from '../constants/Enums';
import BoardKanban from '../components/BoardKanban'; import Board from '../components/Board';
const mapStateToProps = (state) => { const mapStateToProps = (state) => {
const { cardId } = selectors.selectPath(state); const { cardId } = selectors.selectPath(state);
const currentUserMembership = selectors.selectCurrentUserMembershipForCurrentBoard(state); const currentUserMembership = selectors.selectCurrentUserMembershipForCurrentBoard(state);
const listIds = selectors.selectListIdsForCurrentBoard(state); const listIds = selectors.selectListIdsForCurrentBoard(state);
const isCurrentUserEditor =
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR;
return { return {
listIds, listIds,
isCardModalOpened: !!cardId, isCardModalOpened: !!cardId,
canEdit: !!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR, canEdit: isCurrentUserEditor,
}; };
}; };
@@ -28,4 +31,4 @@ const mapDispatchToProps = (dispatch) =>
dispatch, dispatch,
); );
export default connect(mapStateToProps, mapDispatchToProps)(BoardKanban); export default connect(mapStateToProps, mapDispatchToProps)(Board);
@@ -1,15 +0,0 @@
import { connect } from 'react-redux';
import selectors from '../selectors';
import BoardWrapper from '../components/BoardWrapper';
const mapStateToProps = (state) => {
const { type, isFetching } = selectors.selectCurrentBoard(state);
return {
type,
isFetching,
};
};
export default connect(mapStateToProps)(BoardWrapper);
+4 -2
View File
@@ -30,6 +30,9 @@ const makeMapStateToProps = () => {
const tasks = selectTasksByCardId(state, id); const tasks = selectTasksByCardId(state, id);
const notificationsTotal = selectNotificationsTotalByCardId(state, id); const notificationsTotal = selectNotificationsTotalByCardId(state, id);
const isCurrentUserEditor =
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR;
return { return {
id, id,
index, index,
@@ -48,8 +51,7 @@ const makeMapStateToProps = () => {
allProjectsToLists, allProjectsToLists,
allBoardMemberships, allBoardMemberships,
allLabels, allLabels,
canEdit: canEdit: isCurrentUserEditor,
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR,
}; };
}; };
}; };
+11 -6
View File
@@ -1,7 +1,7 @@
import { bindActionCreators } from 'redux'; import { bindActionCreators } from 'redux';
import { connect } from 'react-redux'; import { connect } from 'react-redux';
import { push } from 'redux-first-history';
import omit from 'lodash/omit'; import omit from 'lodash/omit';
import { push } from '../lib/redux-router';
import selectors from '../selectors'; import selectors from '../selectors';
import entryActions from '../entry-actions'; import entryActions from '../entry-actions';
@@ -37,6 +37,14 @@ const mapStateToProps = (state) => {
const attachments = selectors.selectAttachmentsForCurrentCard(state); const attachments = selectors.selectAttachmentsForCurrentCard(state);
const activities = selectors.selectActivitiesForCurrentCard(state); const activities = selectors.selectActivitiesForCurrentCard(state);
let isCurrentUserEditor = false;
let isCurrentUserEditorOrCanComment = false;
if (currentUserMembership) {
isCurrentUserEditor = currentUserMembership.role === BoardMembershipRoles.EDITOR;
isCurrentUserEditorOrCanComment = isCurrentUserEditor || currentUserMembership.canComment;
}
return { return {
name, name,
description, description,
@@ -58,11 +66,8 @@ const mapStateToProps = (state) => {
allProjectsToLists, allProjectsToLists,
allBoardMemberships, allBoardMemberships,
allLabels, allLabels,
canEdit: !!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR, canEdit: isCurrentUserEditor,
canEditCommentActivities: canEditCommentActivities: isCurrentUserEditorOrCanComment,
!!currentUserMembership &&
(currentUserMembership.role === BoardMembershipRoles.EDITOR ||
currentUserMembership.canComment),
canEditAllCommentActivities: isCurrentUserManager, canEditAllCommentActivities: isCurrentUserManager,
}; };
}; };
+4
View File
@@ -4,12 +4,16 @@ import selectors from '../selectors';
import Core from '../components/Core'; import Core from '../components/Core';
const mapStateToProps = (state) => { const mapStateToProps = (state) => {
const isCoreInitializing = selectors.selectIsCoreInitializing(state);
const isSocketDisconnected = selectors.selectIsSocketDisconnected(state);
const currentModal = selectors.selectCurrentModal(state); const currentModal = selectors.selectCurrentModal(state);
const currentProject = selectors.selectCurrentProject(state); const currentProject = selectors.selectCurrentProject(state);
return { return {
isSocketDisconnected,
currentModal, currentModal,
currentProject, currentProject,
isInitializing: isCoreInitializing,
}; };
}; };
@@ -1,15 +0,0 @@
import { connect } from 'react-redux';
import selectors from '../selectors';
import CoreWrapper from '../components/CoreWrapper';
const mapStateToProps = (state) => {
const isCoreInitializing = selectors.selectIsCoreInitializing(state);
return {
isInitializing: isCoreInitializing,
isSocketDisconnected: state.socket.isDisconnected,
};
};
export default connect(mapStateToProps)(CoreWrapper);
+4 -2
View File
@@ -15,14 +15,16 @@ const makeMapStateToProps = () => {
const cardIds = selectCardIdsByListId(state, id); const cardIds = selectCardIdsByListId(state, id);
const currentUserMembership = selectors.selectCurrentUserMembershipForCurrentBoard(state); const currentUserMembership = selectors.selectCurrentUserMembershipForCurrentBoard(state);
const isCurrentUserEditor =
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR;
return { return {
id, id,
index, index,
name, name,
isPersisted, isPersisted,
cardIds, cardIds,
canEdit: canEdit: isCurrentUserEditor,
!!currentUserMembership && currentUserMembership.role === BoardMembershipRoles.EDITOR,
}; };
}; };
}; };
+4 -3
View File
@@ -4,12 +4,13 @@ import selectors from '../selectors';
import Static from '../components/Static'; import Static from '../components/Static';
const mapStateToProps = (state) => { const mapStateToProps = (state) => {
const { cardId, boardId, projectId } = selectors.selectPath(state); const { cardId, projectId } = selectors.selectPath(state);
const currentBoard = selectors.selectCurrentBoard(state);
return { return {
cardId,
boardId,
projectId, projectId,
cardId,
board: currentBoard,
}; };
}; };
+2 -1
View File
@@ -7,10 +7,11 @@ const createBoardInCurrentProject = (data) => ({
}, },
}); });
const handleBoardCreate = (board) => ({ const handleBoardCreate = (board, requestId) => ({
type: EntryActionTypes.BOARD_CREATE_HANDLE, type: EntryActionTypes.BOARD_CREATE_HANDLE,
payload: { payload: {
board, board,
requestId,
}, },
}); });
+3
View File
@@ -0,0 +1,3 @@
import { createBrowserHistory } from 'history';
export default createBrowserHistory();
+2 -1
View File
@@ -1,7 +1,8 @@
import React from 'react'; import React from 'react';
import ReactDOM from 'react-dom/client'; import ReactDOM from 'react-dom/client';
import store, { history } from './store'; import store from './store';
import history from './history';
import Root from './components/Root'; import Root from './components/Root';
import './i18n'; import './i18n';
@@ -3,9 +3,10 @@ import { Input as SemanticUIInput } from 'semantic-ui-react';
import InputPassword from './InputPassword'; import InputPassword from './InputPassword';
import InputMask from './InputMask'; import InputMask from './InputMask';
const Input = SemanticUIInput; export default class Input extends SemanticUIInput {
static Password = InputPassword;
Input.Password = InputPassword; static Mask = InputMask;
Input.Mask = InputMask;
export default Input; focus = (options) => this.inputRef.current.focus(options);
}
@@ -1,8 +1,8 @@
import InputMask from 'react-input-mask'; import InputMask from 'react-input-mask';
export default class MaskedInput extends InputMask { export default class MaskedInput extends InputMask {
focus() { focus(options) {
this.getInputDOMNode().focus(); this.getInputDOMNode().focus(options);
} }
select() { select() {
+14 -3
View File
@@ -6,7 +6,7 @@ import { Button, Popup as SemanticUIPopup } from 'semantic-ui-react';
import styles from './Popup.module.css'; import styles from './Popup.module.css';
export default (WrappedComponent, defaultProps) => { export default (WrappedComponent, defaultProps) => {
const Popup = React.memo(({ children, ...props }) => { const Popup = React.memo(({ children, onClose, ...props }) => {
const [isOpened, setIsOpened] = useState(false); const [isOpened, setIsOpened] = useState(false);
const wrapper = useRef(null); const wrapper = useRef(null);
@@ -18,7 +18,11 @@ export default (WrappedComponent, defaultProps) => {
const handleClose = useCallback(() => { const handleClose = useCallback(() => {
setIsOpened(false); setIsOpened(false);
}, []);
if (onClose) {
onClose();
}
}, [onClose]);
const handleMouseDown = useCallback((event) => { const handleMouseDown = useCallback((event) => {
event.stopPropagation(); event.stopPropagation();
@@ -80,8 +84,10 @@ export default (WrappedComponent, defaultProps) => {
popperModifiers={[ popperModifiers={[
{ {
name: 'preventOverflow', name: 'preventOverflow',
enabled: true,
options: { options: {
boundariesElement: 'window', altAxis: true,
padding: 20,
}, },
}, },
]} ]}
@@ -103,6 +109,11 @@ export default (WrappedComponent, defaultProps) => {
Popup.propTypes = { Popup.propTypes = {
children: PropTypes.node.isRequired, children: PropTypes.node.isRequired,
onClose: PropTypes.func,
};
Popup.defaultProps = {
onClose: undefined,
}; };
return Popup; return Popup;
@@ -0,0 +1,46 @@
import React, { useLayoutEffect } from 'react';
import PropTypes from 'prop-types';
import { useDispatch, useSelector } from 'react-redux';
import { Router } from 'react-router-dom';
import { handleLocationChange } from './actions';
function ReduxRouter({ children, history, selector, basename }) {
const state = useSelector(selector);
const dispatch = useDispatch();
useLayoutEffect(() => {
const unlisten = history.listen((nextState) => {
dispatch(handleLocationChange(nextState.location, nextState.action));
});
dispatch(handleLocationChange(history.location, history.action, true));
return unlisten;
}, [history, dispatch]);
return (
<Router
basename={basename}
location={state.location}
navigationType={state.action}
navigator={history}
>
{children}
</Router>
);
}
ReduxRouter.propTypes = {
children: PropTypes.element.isRequired,
history: PropTypes.object.isRequired, // eslint-disable-line react/forbid-prop-types
selector: PropTypes.func,
basename: PropTypes.string,
};
ReduxRouter.defaultProps = {
selector: ({ router }) => router,
basename: undefined,
};
export default ReduxRouter;
+28
View File
@@ -0,0 +1,28 @@
export const LOCATION_CHANGE_HANDLE = '@@router/LOCATION_CHANGE_HANDLE';
export const handleLocationChange = (location, action, isFirstRendering = false) => ({
type: LOCATION_CHANGE_HANDLE,
payload: {
location,
action,
isFirstRendering,
},
});
export const HISTORY_METHOD_CALL = '@@router/HISTORY_METHOD_CALL';
const createHistoryMethodCaller = (method) => {
return (...args) => ({
type: HISTORY_METHOD_CALL,
payload: {
method,
args,
},
});
};
export const push = createHistoryMethodCaller('push');
export const replace = createHistoryMethodCaller('replace');
export const go = createHistoryMethodCaller('go');
export const back = createHistoryMethodCaller('back');
export const forward = createHistoryMethodCaller('forward');
@@ -0,0 +1,18 @@
import { HISTORY_METHOD_CALL } from './actions';
const createRouterMiddleware = (history) => {
// eslint-disable-next-line consistent-return
return () => (next) => (action) => {
if (action.type !== HISTORY_METHOD_CALL) {
return next(action);
}
const {
payload: { method, args },
} = action;
history[method](...args);
};
};
export default createRouterMiddleware;
@@ -0,0 +1,28 @@
import { LOCATION_CHANGE_HANDLE } from './actions';
const createRouterReducer = (history) => {
const initialState = {
location: history.location,
action: history.action,
};
return (state = initialState, { type, payload } = {}) => {
if (type === LOCATION_CHANGE_HANDLE) {
const { location, action, isFirstRendering } = payload;
if (isFirstRendering) {
return state;
}
return {
...state,
location,
action,
};
}
return state;
};
};
export default createRouterReducer;
+12
View File
@@ -0,0 +1,12 @@
export {
LOCATION_CHANGE_HANDLE,
HISTORY_METHOD_CALL,
push,
replace,
go,
back,
forward,
} from './actions';
export { default as createRouterReducer } from './create-router-reducer';
export { default as createRouterMiddleware } from './create-router-middleware';
export { default as ReduxRouter } from './ReduxRouter';
+4
View File
@@ -9,6 +9,7 @@ export default {
translation: { translation: {
common: { common: {
aboutPlanka: 'About Planka',
account: 'Account', account: 'Account',
actions: 'Actions', actions: 'Actions',
addAttachment_title: 'Add Attachment', addAttachment_title: 'Add Attachment',
@@ -92,8 +93,10 @@ export default {
filterByLabels_title: 'Filter By Labels', filterByLabels_title: 'Filter By Labels',
filterByMembers_title: 'Filter By Members', filterByMembers_title: 'Filter By Members',
fromComputer_title: 'From Computer', fromComputer_title: 'From Computer',
fromTrello: 'From Trello',
general: 'General', general: 'General',
hours: 'Hours', hours: 'Hours',
importBoard_title: 'Import Board',
invalidCurrentPassword: 'Invalid current password', invalidCurrentPassword: 'Invalid current password',
labels: 'Labels', labels: 'Labels',
language: 'Language', language: 'Language',
@@ -201,6 +204,7 @@ export default {
editTitle_title: 'Edit Title', editTitle_title: 'Edit Title',
editUsername_title: 'Edit Username', editUsername_title: 'Edit Username',
hideDetails: 'Hide details', hideDetails: 'Hide details',
import: 'Import',
leaveBoard: 'Leave board', leaveBoard: 'Leave board',
leaveProject: 'Leave project', leaveProject: 'Leave project',
logOut_title: 'Log Out', logOut_title: 'Log Out',
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm'; import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
export default class extends Model { export default class extends BaseModel {
static modelName = 'Activity'; static modelName = 'Activity';
static fields = { static fields = {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm'; import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
export default class extends Model { export default class extends BaseModel {
static modelName = 'Attachment'; static modelName = 'Attachment';
static fields = { static fields = {
+6
View File
@@ -0,0 +1,6 @@
import { Model } from 'redux-orm';
export default class BaseModel extends Model {
// eslint-disable-next-line no-underscore-dangle, class-methods-use-this
_onDelete() {}
}
+20 -10
View File
@@ -1,13 +1,13 @@
import { Model, attr, fk, many } from 'redux-orm'; import { attr, fk, many } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
export default class extends Model { export default class extends BaseModel {
static modelName = 'Board'; static modelName = 'Board';
static fields = { static fields = {
id: attr(), id: attr(),
type: attr(),
position: attr(), position: attr(),
name: attr(), name: attr(),
isFetching: attr({ isFetching: attr({
@@ -30,11 +30,12 @@ export default class extends Model {
static reducer({ type, payload }, Board) { static reducer({ type, payload }, Board) {
switch (type) { switch (type) {
case ActionTypes.LOCATION_CHANGE_HANDLE: case ActionTypes.LOCATION_CHANGE_HANDLE:
case ActionTypes.BOARD_FETCH__SUCCESS: if (payload.board) {
Board.upsert({ Board.upsert({
...payload.board, ...payload.board,
isFetching: false, isFetching: false,
}); });
}
break; break;
case ActionTypes.LOCATION_CHANGE_HANDLE__BOARD_FETCH: case ActionTypes.LOCATION_CHANGE_HANDLE__BOARD_FETCH:
@@ -124,7 +125,10 @@ export default class extends Model {
break; break;
case ActionTypes.BOARD_CREATE__SUCCESS: case ActionTypes.BOARD_CREATE__SUCCESS:
Board.withId(payload.localId).delete(); Board.withId(payload.localId).delete();
Board.upsert(payload.board);
break;
case ActionTypes.BOARD_FETCH__SUCCESS:
Board.upsert({ Board.upsert({
...payload.board, ...payload.board,
isFetching: false, isFetching: false,
@@ -175,7 +179,7 @@ export default class extends Model {
return this.lists.orderBy('position'); return this.lists.orderBy('position');
} }
getMembershipModel(userId) { getMembershipModelForUser(userId) {
return this.memberships return this.memberships
.filter({ .filter({
userId, userId,
@@ -183,7 +187,7 @@ export default class extends Model {
.first(); .first();
} }
hasMemberUser(userId) { hasMembershipForUser(userId) {
return this.memberships return this.memberships
.filter({ .filter({
userId, userId,
@@ -191,6 +195,12 @@ export default class extends Model {
.exists(); .exists();
} }
isAvailableForUser(userId) {
return (
this.project && (this.project.hasManagerForUser(userId) || this.hasMembershipForUser(userId))
);
}
deleteRelated(exceptMemberUserId) { deleteRelated(exceptMemberUserId) {
this.memberships.toModelArray().forEach((boardMembershipModel) => { this.memberships.toModelArray().forEach((boardMembershipModel) => {
if (boardMembershipModel.userId !== exceptMemberUserId) { if (boardMembershipModel.userId !== exceptMemberUserId) {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm'; import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
export default class extends Model { export default class extends BaseModel {
static modelName = 'BoardMembership'; static modelName = 'BoardMembership';
static fields = { static fields = {
+38 -14
View File
@@ -1,10 +1,11 @@
import { Model, attr, fk, many, oneToOne } from 'redux-orm'; import { attr, fk, many, oneToOne } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
import Config from '../constants/Config'; import Config from '../constants/Config';
import { ActivityTypes } from '../constants/Enums'; import { ActivityTypes } from '../constants/Enums';
export default class extends Model { export default class extends BaseModel {
static modelName = 'Card'; static modelName = 'Card';
static fields = { static fields = {
@@ -74,7 +75,11 @@ export default class extends Model {
break; break;
case ActionTypes.SOCKET_RECONNECT_HANDLE: case ActionTypes.SOCKET_RECONNECT_HANDLE:
Card.all().delete(); Card.all()
.toModelArray()
.forEach((cardModel) => {
cardModel.deleteWithClearable();
});
if (payload.cards) { if (payload.cards) {
payload.cards.forEach((card) => { payload.cards.forEach((card) => {
@@ -176,7 +181,7 @@ export default class extends Model {
break; break;
case ActionTypes.CARD_DELETE: case ActionTypes.CARD_DELETE:
Card.withId(payload.id).delete(); Card.withId(payload.id).deleteWithRelated();
break; break;
case ActionTypes.CARD_DELETE__SUCCESS: case ActionTypes.CARD_DELETE__SUCCESS:
@@ -220,15 +225,7 @@ export default class extends Model {
isActivitiesDetailsFetching: false, isActivitiesDetailsFetching: false,
}); });
cardModel.activities.toModelArray().forEach((activityModel) => { cardModel.deleteActivities();
if (activityModel.notification) {
activityModel.update({
isInCard: false,
});
} else {
activityModel.delete();
}
});
break; break;
} }
@@ -268,10 +265,37 @@ export default class extends Model {
}); });
} }
isAvailableForUser(userId) {
return this.board && this.board.isAvailableForUser(userId);
}
deleteClearable() {
this.users.clear();
this.labels.clear();
}
deleteActivities() {
this.activities.toModelArray().forEach((activityModel) => {
if (activityModel.notification) {
activityModel.update({
isInCard: false,
});
} else {
activityModel.delete();
}
});
}
deleteRelated() { deleteRelated() {
this.deleteClearable();
this.tasks.delete(); this.tasks.delete();
this.attachments.delete(); this.attachments.delete();
this.activities.delete(); this.deleteActivities();
}
deleteWithClearable() {
this.deleteClearable();
this.delete();
} }
deleteWithRelated() { deleteWithRelated() {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm'; import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
export default class extends Model { export default class extends BaseModel {
static modelName = 'Label'; static modelName = 'Label';
static fields = { static fields = {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm'; import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
export default class extends Model { export default class extends BaseModel {
static modelName = 'List'; static modelName = 'List';
static fields = { static fields = {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk, oneToOne } from 'redux-orm'; import { attr, fk, oneToOne } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
export default class extends Model { export default class extends BaseModel {
static modelName = 'Notification'; static modelName = 'Notification';
static fields = { static fields = {
+15 -10
View File
@@ -1,9 +1,10 @@
import { Model, attr, many } from 'redux-orm'; import { attr, many } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
import { ProjectBackgroundTypes } from '../constants/Enums'; import { ProjectBackgroundTypes } from '../constants/Enums';
export default class extends Model { export default class extends BaseModel {
static modelName = 'Project'; static modelName = 'Project';
static fields = { static fields = {
@@ -143,21 +144,21 @@ export default class extends Model {
return this.boards.orderBy('position'); return this.boards.orderBy('position');
} }
getOrderedMemberBoardsModelArray(userId) { getOrderedBoardsModelArrayForUser(userId) {
return this.getOrderedBoardsQuerySet() return this.getOrderedBoardsQuerySet()
.toModelArray() .toModelArray()
.filter((boardModel) => boardModel.hasMemberUser(userId)); .filter((boardModel) => boardModel.hasMembershipForUser(userId));
} }
getOrderedAvailableBoardsModelArray(userId) { getOrderedBoardsModelArrayAvailableForUser(userId) {
if (this.hasManagerUser(userId)) { if (this.hasManagerForUser(userId)) {
return this.getOrderedBoardsQuerySet().toModelArray(); return this.getOrderedBoardsQuerySet().toModelArray();
} }
return this.getOrderedMemberBoardsModelArray(userId); return this.getOrderedBoardsModelArrayForUser(userId);
} }
hasManagerUser(userId) { hasManagerForUser(userId) {
return this.managers return this.managers
.filter({ .filter({
userId, userId,
@@ -165,8 +166,12 @@ export default class extends Model {
.exists(); .exists();
} }
hasMemberUserForAnyBoard(userId) { hasMembershipInAnyBoardForUser(userId) {
return this.boards.toModelArray().some((boardModel) => boardModel.hasMemberUser(userId)); return this.boards.toModelArray().some((boardModel) => boardModel.hasMembershipForUser(userId));
}
isAvailableForUser(userId) {
return this.hasManagerForUser(userId) || this.hasMembershipInAnyBoardForUser(userId);
} }
deleteRelated() { deleteRelated() {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm'; import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
export default class extends Model { export default class extends BaseModel {
static modelName = 'ProjectManager'; static modelName = 'ProjectManager';
static fields = { static fields = {
+3 -2
View File
@@ -1,8 +1,9 @@
import { Model, attr, fk } from 'redux-orm'; import { attr, fk } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
export default class extends Model { export default class extends BaseModel {
static modelName = 'Task'; static modelName = 'Task';
static fields = { static fields = {
+3 -2
View File
@@ -1,5 +1,6 @@
import { Model, attr } from 'redux-orm'; import { attr } from 'redux-orm';
import BaseModel from './BaseModel';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
const DEFAULT_EMAIL_UPDATE_FORM = { const DEFAULT_EMAIL_UPDATE_FORM = {
@@ -29,7 +30,7 @@ const DEFAULT_USERNAME_UPDATE_FORM = {
error: null, error: null,
}; };
export default class extends Model { export default class extends BaseModel {
static modelName = 'User'; static modelName = 'User';
static fields = { static fields = {
+2 -2
View File
@@ -1,4 +1,4 @@
import { LOCATION_CHANGE } from 'redux-first-history'; import { LOCATION_CHANGE_HANDLE } from '../lib/redux-router';
import ActionTypes from '../constants/ActionTypes'; import ActionTypes from '../constants/ActionTypes';
import ModalTypes from '../constants/ModalTypes'; import ModalTypes from '../constants/ModalTypes';
@@ -12,7 +12,7 @@ const initialState = {
// eslint-disable-next-line default-param-last // eslint-disable-next-line default-param-last
export default (state = initialState, { type, payload }) => { export default (state = initialState, { type, payload }) => {
switch (type) { switch (type) {
case LOCATION_CHANGE: case LOCATION_CHANGE_HANDLE:
case ActionTypes.MODAL_CLOSE: case ActionTypes.MODAL_CLOSE:
return { return {
...state, ...state,
+4 -2
View File
@@ -1,3 +1,5 @@
import { routerReducer } from '../redux-history-context'; import { createRouterReducer } from '../lib/redux-router';
export default routerReducer; import history from '../history';
export default createRouterReducer(history);
-6
View File
@@ -1,6 +0,0 @@
import { createBrowserHistory } from 'history';
import { createReduxHistoryContext } from 'redux-first-history';
export const { createReduxHistory, routerMiddleware, routerReducer } = createReduxHistoryContext({
history: createBrowserHistory(),
});
+20 -4
View File
@@ -7,7 +7,7 @@ import actions from '../../../actions';
import api from '../../../api'; import api from '../../../api';
import { createLocalId } from '../../../utils/local-id'; import { createLocalId } from '../../../utils/local-id';
export function* createBoard(projectId, data) { export function* createBoard(projectId, { import: boardImport, ...data }) {
const nextData = { const nextData = {
...data, ...data,
position: yield select(selectors.selectNextBoardPosition, projectId), position: yield select(selectors.selectNextBoardPosition, projectId),
@@ -30,7 +30,19 @@ export function* createBoard(projectId, data) {
({ ({
item: board, item: board,
included: { boardMemberships }, included: { boardMemberships },
} = yield call(request, api.createBoard, projectId, nextData)); } = yield boardImport
? call(
request,
api.createBoardWithImport,
projectId,
{
...nextData,
importType: boardImport.type,
importFile: boardImport.file,
},
localId,
)
: call(request, api.createBoard, projectId, nextData));
} catch (error) { } catch (error) {
yield put(actions.createBoard.failure(localId, error)); yield put(actions.createBoard.failure(localId, error));
return; return;
@@ -46,8 +58,12 @@ export function* createBoardInCurrentProject(data) {
yield call(createBoard, projectId, data); yield call(createBoard, projectId, data);
} }
export function* handleBoardCreate(board) { export function* handleBoardCreate(board, requestId) {
yield put(actions.handleBoardCreate(board)); const isExists = yield select(selectors.selectIsBoardWithIdExists, requestId);
if (!isExists) {
yield put(actions.handleBoardCreate(board));
}
} }
export function* fetchBoard(id) { export function* fetchBoard(id) {
+4 -3
View File
@@ -12,7 +12,6 @@ export function* createCard(listId, data) {
const nextData = { const nextData = {
...data, ...data,
listId,
position: yield select(selectors.selectNextCardPosition, listId), position: yield select(selectors.selectNextCardPosition, listId),
}; };
@@ -22,13 +21,14 @@ export function* createCard(listId, data) {
actions.createCard({ actions.createCard({
...nextData, ...nextData,
boardId, boardId,
listId,
id: localId, id: localId,
}), }),
); );
let card; let card;
try { try {
({ item: card } = yield call(request, api.createCard, boardId, nextData)); ({ item: card } = yield call(request, api.createCard, listId, nextData));
} catch (error) { } catch (error) {
yield put(actions.createCard.failure(localId, error)); yield put(actions.createCard.failure(localId, error));
return; return;
@@ -61,8 +61,9 @@ export function* updateCurrentCard(data) {
yield call(updateCard, cardId, data); yield call(updateCard, cardId, data);
} }
// TODO: handle card transfer
export function* handleCardUpdate(card) { export function* handleCardUpdate(card) {
yield put(actions.handleCardUpdate(card)); // TODO: handle card transfer yield put(actions.handleCardUpdate(card));
} }
export function* moveCard(id, listId, index) { export function* moveCard(id, listId, index) {
+6 -6
View File
@@ -39,8 +39,8 @@ export function* createListInCurrentBoard(data) {
yield call(createList, boardId, data); yield call(createList, boardId, data);
} }
export function* handleListCreate(label) { export function* handleListCreate(list) {
yield put(actions.handleListCreate(label)); yield put(actions.handleListCreate(list));
} }
export function* updateList(id, data) { export function* updateList(id, data) {
@@ -57,8 +57,8 @@ export function* updateList(id, data) {
yield put(actions.updateList.success(list)); yield put(actions.updateList.success(list));
} }
export function* handleListUpdate(label) { export function* handleListUpdate(list) {
yield put(actions.handleListUpdate(label)); yield put(actions.handleListUpdate(list));
} }
export function* moveList(id, index) { export function* moveList(id, index) {
@@ -84,8 +84,8 @@ export function* deleteList(id) {
yield put(actions.deleteList.success(list)); yield put(actions.deleteList.success(list));
} }
export function* handleListDelete(label) { export function* handleListDelete(list) {
yield put(actions.handleListDelete(label)); yield put(actions.handleListDelete(list));
} }
export default { export default {
@@ -24,6 +24,7 @@ export function* createProjectManager(projectId, data) {
({ item: projectManager } = yield call(request, api.createProjectManager, projectId, data)); ({ item: projectManager } = yield call(request, api.createProjectManager, projectId, data));
} catch (error) { } catch (error) {
yield put(actions.createProjectManager.failure(localId, error)); yield put(actions.createProjectManager.failure(localId, error));
return;
} }
yield put(actions.createProjectManager.success(localId, projectManager)); yield put(actions.createProjectManager.success(localId, projectManager));
@@ -53,6 +53,7 @@ export function* updateProject(id, data) {
({ item: project } = yield call(request, api.updateProject, id, data)); ({ item: project } = yield call(request, api.updateProject, id, data));
} catch (error) { } catch (error) {
yield put(actions.updateProject.failure(id, error)); yield put(actions.updateProject.failure(id, error));
return;
} }
yield put(actions.updateProject.success(project)); yield put(actions.updateProject.success(project));
@@ -76,6 +77,7 @@ export function* updateProjectBackgroundImage(id, data) {
({ item: project } = yield call(request, api.updateProjectBackgroundImage, id, data)); ({ item: project } = yield call(request, api.updateProjectBackgroundImage, id, data));
} catch (error) { } catch (error) {
yield put(actions.updateProjectBackgroundImage.failure(id, error)); yield put(actions.updateProjectBackgroundImage.failure(id, error));
return;
} }
yield put(actions.updateProjectBackgroundImage.success(project)); yield put(actions.updateProjectBackgroundImage.success(project));
@@ -101,6 +103,7 @@ export function* deleteProject(id) {
({ item: project } = yield call(request, api.deleteProject, id)); ({ item: project } = yield call(request, api.deleteProject, id));
} catch (error) { } catch (error) {
yield put(actions.deleteProject.failure(id, error)); yield put(actions.deleteProject.failure(id, error));
return;
} }
yield put(actions.deleteProject.success(project)); yield put(actions.deleteProject.success(project));
+1 -1
View File
@@ -1,5 +1,5 @@
import { call, put, select, take } from 'redux-saga/effects'; import { call, put, select, take } from 'redux-saga/effects';
import { push } from 'redux-first-history'; import { push } from '../../../lib/redux-router';
import request from '../request'; import request from '../request';
import selectors from '../../../selectors'; import selectors from '../../../selectors';
+2 -2
View File
@@ -8,8 +8,8 @@ export default function* boardsWatchers() {
takeEvery(EntryActionTypes.BOARD_IN_CURRENT_PROJECT_CREATE, ({ payload: { data } }) => takeEvery(EntryActionTypes.BOARD_IN_CURRENT_PROJECT_CREATE, ({ payload: { data } }) =>
services.createBoardInCurrentProject(data), services.createBoardInCurrentProject(data),
), ),
takeEvery(EntryActionTypes.BOARD_CREATE_HANDLE, ({ payload: { board } }) => takeEvery(EntryActionTypes.BOARD_CREATE_HANDLE, ({ payload: { board, requestId } }) =>
services.handleBoardCreate(board), services.handleBoardCreate(board, requestId),
), ),
takeEvery(EntryActionTypes.BOARD_FETCH, ({ payload: { id } }) => services.fetchBoard(id)), takeEvery(EntryActionTypes.BOARD_FETCH, ({ payload: { id } }) => services.fetchBoard(id)),
takeEvery(EntryActionTypes.BOARD_UPDATE, ({ payload: { id, data } }) => takeEvery(EntryActionTypes.BOARD_UPDATE, ({ payload: { id, data } }) =>
+2 -2
View File
@@ -1,8 +1,8 @@
import { takeEvery } from 'redux-saga/effects'; import { takeEvery } from 'redux-saga/effects';
import { LOCATION_CHANGE } from 'redux-first-history'; import { LOCATION_CHANGE_HANDLE } from '../../../lib/redux-router';
import services from '../services'; import services from '../services';
export default function* routerWatchers() { export default function* routerWatchers() {
yield takeEvery(LOCATION_CHANGE, () => services.handleLocationChange()); yield takeEvery(LOCATION_CHANGE_HANDLE, () => services.handleLocationChange());
} }
+2 -2
View File
@@ -48,8 +48,8 @@ const createSocketEventsChannel = () =>
emit(entryActions.handleProjectManagerDelete(item)); emit(entryActions.handleProjectManagerDelete(item));
}; };
const handleBoardCreate = ({ item }) => { const handleBoardCreate = ({ item, requestId }) => {
emit(entryActions.handleBoardCreate(item)); emit(entryActions.handleBoardCreate(item, requestId));
}; };
const handleBoardUpdate = ({ item }) => { const handleBoardUpdate = ({ item }) => {
+1 -1
View File
@@ -1,5 +1,5 @@
import { call, put, select } from 'redux-saga/effects'; import { call, put, select } from 'redux-saga/effects';
import { push } from 'redux-first-history'; import { push } from '../../../lib/redux-router';
import selectors from '../../../selectors'; import selectors from '../../../selectors';
import Paths from '../../../constants/Paths'; import Paths from '../../../constants/Paths';
+2 -2
View File
@@ -1,8 +1,8 @@
import { takeEvery } from 'redux-saga/effects'; import { takeEvery } from 'redux-saga/effects';
import { LOCATION_CHANGE } from 'redux-first-history'; import { LOCATION_CHANGE_HANDLE } from '../../../lib/redux-router';
import services from '../services'; import services from '../services';
export default function* routerWatchers() { export default function* routerWatchers() {
yield takeEvery(LOCATION_CHANGE, () => services.handleLocationChange()); yield takeEvery(LOCATION_CHANGE_HANDLE, () => services.handleLocationChange());
} }
+30 -23
View File
@@ -69,6 +69,31 @@ export const selectMembershipsForCurrentBoard = createSelector(
}, },
); );
export const selectCurrentUserMembershipForCurrentBoard = createSelector(
orm,
(state) => selectPath(state).boardId,
(state) => selectCurrentUserId(state),
({ Board }, id, currentUserId) => {
if (!id) {
return id;
}
const boardModel = Board.withId(id);
if (!boardModel) {
return boardModel;
}
const boardMembershipModel = boardModel.getMembershipModelForUser(currentUserId);
if (!boardMembershipModel) {
return boardMembershipModel;
}
return boardMembershipModel.ref;
},
);
export const selectLabelsForCurrentBoard = createSelector( export const selectLabelsForCurrentBoard = createSelector(
orm, orm,
(state) => selectPath(state).boardId, (state) => selectPath(state).boardId,
@@ -147,29 +172,10 @@ export const selectFilterLabelsForCurrentBoard = createSelector(
}, },
); );
export const selectCurrentUserMembershipForCurrentBoard = createSelector( export const selectIsBoardWithIdExists = createSelector(
orm, orm,
(state) => selectPath(state).boardId, (_, id) => id,
(state) => selectCurrentUserId(state), ({ Board }, id) => Board.idExists(id),
({ Board }, id, currentUserId) => {
if (!id) {
return id;
}
const boardModel = Board.withId(id);
if (!boardModel) {
return boardModel;
}
const boardMembershipModel = boardModel.getMembershipModel(currentUserId);
if (!boardMembershipModel) {
return boardMembershipModel;
}
return boardMembershipModel.ref;
},
); );
export default { export default {
@@ -177,9 +183,10 @@ export default {
selectBoardById, selectBoardById,
selectCurrentBoard, selectCurrentBoard,
selectMembershipsForCurrentBoard, selectMembershipsForCurrentBoard,
selectCurrentUserMembershipForCurrentBoard,
selectLabelsForCurrentBoard, selectLabelsForCurrentBoard,
selectListIdsForCurrentBoard, selectListIdsForCurrentBoard,
selectFilterUsersForCurrentBoard, selectFilterUsersForCurrentBoard,
selectFilterLabelsForCurrentBoard, selectFilterLabelsForCurrentBoard,
selectCurrentUserMembershipForCurrentBoard, selectIsBoardWithIdExists,
}; };
+2
View File
@@ -1,4 +1,5 @@
import router from './router'; import router from './router';
import socket from './socket';
import core from './core'; import core from './core';
import modals from './modals'; import modals from './modals';
import users from './users'; import users from './users';
@@ -13,6 +14,7 @@ import attachments from './attachments';
export default { export default {
...router, ...router,
...socket,
...core, ...core,
...modals, ...modals,
...users, ...users,
+7 -5
View File
@@ -67,10 +67,12 @@ export const selectBoardsForCurrentProject = createSelector(
return projectModel; return projectModel;
} }
return projectModel.getOrderedAvailableBoardsModelArray(currentUserId).map((boardModel) => ({ return projectModel
...boardModel.ref, .getOrderedBoardsModelArrayAvailableForUser(currentUserId)
isPersisted: !isLocalId(boardModel.id), .map((boardModel) => ({
})); ...boardModel.ref,
isPersisted: !isLocalId(boardModel.id),
}));
}, },
); );
@@ -89,7 +91,7 @@ export const selectIsCurrentUserManagerForCurrentProject = createSelector(
return false; return false;
} }
return projectModel.hasManagerUser(currentUserId); return projectModel.hasManagerForUser(currentUserId);
}, },
); );
+6 -36
View File
@@ -26,55 +26,35 @@ export const selectPath = createReduxOrmSelector(
case Paths.PROJECTS: { case Paths.PROJECTS: {
const projectModel = Project.withId(pathsMatch.params.id); const projectModel = Project.withId(pathsMatch.params.id);
if (!projectModel) { if (!projectModel || !projectModel.isAvailableForUser(currentUserId)) {
return { return {
projectId: null, projectId: null,
}; };
} }
if (!projectModel.hasManagerUser(currentUserId)) {
if (!projectModel.hasMemberUserForAnyBoard(currentUserId)) {
return {
projectId: null,
};
}
}
return { return {
projectId: projectModel.id, projectId: projectModel.id,
}; };
} }
case Paths.BOARDS: { case Paths.BOARDS: {
const boardModel = Board.withId(pathsMatch.params.id); const boardModel = Board.withId(pathsMatch.params.id);
const projectModel = boardModel && boardModel.project;
if (!projectModel) { if (!boardModel || !boardModel.isAvailableForUser(currentUserId)) {
return { return {
boardId: null, boardId: null,
projectId: null, projectId: null,
}; };
} }
if (!projectModel.hasManagerUser(currentUserId)) {
if (!boardModel.hasMemberUser(currentUserId)) {
return {
boardId: null,
projectId: null,
};
}
}
return { return {
boardId: boardModel.id, boardId: boardModel.id,
projectId: projectModel.id, projectId: boardModel.projectId,
}; };
} }
case Paths.CARDS: { case Paths.CARDS: {
const cardModel = Card.withId(pathsMatch.params.id); const cardModel = Card.withId(pathsMatch.params.id);
const boardModel = cardModel && cardModel.board;
const projectModel = boardModel && boardModel.project;
if (!projectModel) { if (!cardModel || !cardModel.isAvailableForUser(currentUserId)) {
return { return {
cardId: null, cardId: null,
boardId: null, boardId: null,
@@ -82,20 +62,10 @@ export const selectPath = createReduxOrmSelector(
}; };
} }
if (!projectModel.hasManagerUser(currentUserId)) {
if (!boardModel.hasMemberUser(currentUserId)) {
return {
cardId: null,
boardId: null,
projectId: null,
};
}
}
return { return {
cardId: cardModel.id, cardId: cardModel.id,
boardId: boardModel.id, boardId: cardModel.boardId,
projectId: projectModel.id, projectId: cardModel.board.projectId,
}; };
} }
default: default:

Some files were not shown because too many files have changed in this diff Show More