Commit Graph

444 Commits (2f50b0e8cf551cdffd3d583c0626db0b1839a7f1)
 

Author SHA1 Message Date
NavyStack 2f50b0e8cf Hide docker-compose command to start.sh 2 years ago
NavyStack 92366fd469
. 2 years ago
NavyStack 30341f0494
Improve signal handlers 2 years ago
NavyStack 8c340160c1
Merge branch 'plankanban:master' into master 2 years ago
Maksim Eltyshev da63598de3 chore: Update version 2 years ago
Gilberto Vidal 517cb34cfe
fix: Fix eslint rules for Windows (#508) 2 years ago
NavyStack c9b8862a90
Merge branch 'plankanban:master' into master 2 years ago
NavyStack 079b8eba53
fix: Fine-tune Korean and Japanese translations, fix full stops (#561) 2 years ago
Navystack e8b239af48 Korean and Japanese fine tune. 2 years ago
NavyStack a67b6767bf
Merge branch 'plankanban:master' into master 2 years ago
Maksim Eltyshev af02cdd8bf docs: Little readme fixes 2 years ago
Maksim Eltyshev 7dea93103c fix: Unify all translations 2 years ago
Maksim Eltyshev e1bc189b88 chore: Bump chart-releaser-action version 2 years ago
Maksim Eltyshev 5f2723623a chore: Update version 2 years ago
Maksim Eltyshev fee6841d0a fix: Attempt to fix error that occurs during reconnection 2 years ago
Maksim Eltyshev ca6fb3b962 fix: Add state parameter to OIDC authorization url
Closes #558
2 years ago
Maksim Eltyshev 28c3f28e01 fix: Add issuer to OIDC callback parameters
Closes #562
2 years ago
NavyStack c4ed3d133c . 2 years ago
Maksim Eltyshev 80d12aaeeb fix: Fix Korean translation linting 2 years ago
NavyStack 89af209a2e
fix: Update Korean translation (#560) 2 years ago
Maksim Eltyshev f1fed3e533 build: Stop using base image 2 years ago
Maksim Eltyshev eddeb96b16 fix: Fix Romanian translation linting 2 years ago
Maksim Eltyshev 9e8ff3b579 chore: Revert remark-gfm update 2 years ago
Maksim Eltyshev fc1278011c build: Use pnpm import before installing dependencies 2 years ago
Andrei Covali 24163463fc
feat: Add Romanian translation (#555) 2 years ago
Yu Inoue fdef87e3b9
fix: Add support for OIDC configuration thru Helm (#550)
Closes #548
2 years ago
Maksim Eltyshev 964498dbaa chore: Use Node v18 2 years ago
Maksim Eltyshev 5b519cb62f chore: Update version 2 years ago
Yu Inoue 11fc3b4485
fix: Separate service port and container port in Helm (#549) 2 years ago
Maksim Eltyshev 37c0b59f82 chore: Update vips version 2 years ago
Maksim Eltyshev 239611ad51 chore: Update dependencies 2 years ago
Yu Inoue 0575e665fe
fix: Fix time format in Japanese locale (#546)
Closes #542
2 years ago
Maksim Eltyshev 019766dced chore: Update version 2 years ago
Maksim Eltyshev 6dc9e4ed99 fix: Disable role change when OIDC roles are not ignored 2 years ago
Balthasar Hofer d4b64b90fc
feat: Add ability to ignore roles when logging in with SSO (#534)
Closes #533
2 years ago
Daniel Hiller 1a49826b85 docs: adjust filenames to match the docs 2 years ago
Daniel Hiller 815643eb2c ci: ignore some paths on push 2 years ago
Daniel Hiller bcc4c0d923 chore: update version 2 years ago
Daniel Hiller cf7810b067 fix: add admin user variables 2 years ago
Maksim Eltyshev f1c72df8b6 chore: Update version 2 years ago
Maksim Eltyshev 5056d38848 fix: Fix logging out with invalid token 2 years ago
Maksim Eltyshev 3ef5b3ead8 fix: Make default admin environment variables optional
Closes #526
2 years ago
Vishnu Kaushik ded58dc8b0
fix: Add task counter in card modal (#525)
Closes #467
2 years ago
Maksim Eltyshev d8ee1ecdd1 ci: Do not mark released chart as latest 2 years ago
Maksim Eltyshev fc2f4cd5d3 chore: Update version 2 years ago
Maksim Eltyshev 7ef457157e fix: Fallback to query if there is no fragment 2 years ago
Maksim Eltyshev 23ee815200 chore: Update version 2 years ago
Maksim Eltyshev 40c04c35ff ref: Refactoring 2 years ago
Lorenz Brun 743f2956c8
feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2 years ago
Maksim Eltyshev 5bf5db27d8 chore: Update chart version 2 years ago