chore: replace axios by fetch

Fix lint errors too
pull/676/head
Matthieu Bollot 2 years ago
parent 9b6766cff6
commit 4e02efa0ee
No known key found for this signature in database
GPG Key ID: 426E24F35CBB5BC2

@ -56,7 +56,6 @@
} }
}, },
"dependencies": { "dependencies": {
"axios": "^1.6.2",
"concurrently": "^8.2.2", "concurrently": "^8.2.2",
"husky": "^8.0.3", "husky": "^8.0.3",
"lint-staged": "^15.1.0" "lint-staged": "^15.1.0"

@ -111,10 +111,10 @@ module.exports = {
.intercept('positionMustBeInValues', () => Errors.POSITION_MUST_BE_PRESENT); .intercept('positionMustBeInValues', () => Errors.POSITION_MUST_BE_PRESENT);
const cardUrl = services.buildCardUrl(card); const cardUrl = services.buildCardUrl(card);
const messageText = cardUrl + ' was created by ' + currentUser.name + ' in *' + list.name + '*'; const messageText = `${cardUrl} was created by ${currentUser.name} in *${list.name}*`;
services.sendSlackMessage(messageText) services.sendSlackMessage(messageText).catch((error) => {
.then(() => { console.log('Slack message sent successfully.'); }) throw new Error('Failed to send Slack message:', error.message);
.catch((error) => { console.error('Failed to send Slack message:', error.message); }); });
return { return {
item: card, item: card,

@ -56,10 +56,10 @@ module.exports = {
throw Errors.CARD_NOT_FOUND; throw Errors.CARD_NOT_FOUND;
} }
const messageText = '*' + card.name + '* was deleted by ' + currentUser.name; const messageText = `*${card.name}* was deleted by ${currentUser.name}`;
services.sendSlackMessage(messageText) services.sendSlackMessage(messageText).catch((error) => {
.then(() => { console.log('Slack message sent successfully.'); }) throw new Error('Failed to send Slack message:', error.message);
.catch((error) => { console.error('Failed to send Slack message:', error.message); }); });
return { return {
item: card, item: card,

@ -203,10 +203,10 @@ module.exports = {
if (cardMoved) { if (cardMoved) {
const cardUrl = services.buildCardUrl(card); const cardUrl = services.buildCardUrl(card);
const messageText = cardUrl + ' was moved by ' + currentUser.name + ' to *' + nextList.name + '*'; const messageText = `${cardUrl} was moved by ${currentUser.name} to *${nextList.name}*`;
services.sendSlackMessage(messageText) services.sendSlackMessage(messageText).catch((error) => {
.then(() => { console.log('Slack message sent successfully.'); }) throw new Error('Failed to send Slack message:', error.message);
.catch((error) => { console.error('Failed to send Slack message:', error.message); }); });
} }
return { return {

@ -67,10 +67,10 @@ module.exports = {
}); });
const cardUrl = services.buildCardUrl(card); const cardUrl = services.buildCardUrl(card);
const messageText = '*' + currentUser.name + '* commented on ' + cardUrl + ':\n>' + inputs.text; const messageText = `*${currentUser.name}* commented on ${cardUrl}:\n>${inputs.text}`;
services.sendSlackMessage(messageText) services.sendSlackMessage(messageText).catch((error) => {
.then(() => { console.log('Slack message sent successfully.'); }) throw new Error('Failed to send Slack message:', error.message);
.catch((error) => { console.error('Failed to send Slack message:', error.message); }); });
return { return {
item: action, item: action,

@ -1,4 +1,3 @@
const axios = require('axios');
const slackPostUrl = 'https://slack.com/api/chat.postMessage'; const slackPostUrl = 'https://slack.com/api/chat.postMessage';
const channelId = process.env.SLACK_CHANNEL_ID; const channelId = process.env.SLACK_CHANNEL_ID;
const slackAPIToken = process.env.SLACK_BOT_TOKEN; const slackAPIToken = process.env.SLACK_BOT_TOKEN;
@ -9,50 +8,54 @@ async function sendSlackMessage(messageText) {
throw new Error('No Slack BOT token found'); throw new Error('No Slack BOT token found');
} }
console.log('Sending to Slack');
const postData = { const postData = {
blocks: [ { blocks: [
{
type: 'section', type: 'section',
text: { text: {
type: 'mrkdwn', type: 'mrkdwn',
text: messageText, text: messageText,
}, },
}] },
],
channel: channelId,
}; };
try {
const config = { const config = {
headers: { headers: {
'Content-Type': 'application/json', 'Content-Type': 'application/json; charset=utf-8',
'Authorization': `Bearer ${slackAPIToken}`, Authorization: `Bearer ${slackAPIToken}`,
}, },
}; };
axios.post(slackPostUrl, { ...postData, channel: channelId }, config) const response = await fetch(slackPostUrl, {
.then(response => { method: 'POST',
console.log('Slack response:', response.data); headers: config.headers,
}) body: JSON.stringify(postData),
.catch(error => {
console.error('Error sending to Slack:', error.message);
}); });
console.log('Slack response:', response.data); if (!response.ok) {
return response.data; sails.log.Error('Error sending to Slack :', response.error);
} catch (error) { return Promise.reject(response);
console.error('Error sending to Slack:', error.message);
throw error;
} }
const responseText = await new Response(response.body).text();
const jsonBody = JSON.parse(responseText);
if (!jsonBody.ok) {
sails.log.Error('Error sending to Slack :', jsonBody.error);
return Promise.reject(response);
}
return response;
} }
function buildCardUrl(card) { function buildCardUrl(card) {
const url = plankaProdUrl + '/cards/' + card.id; const url = `${plankaProdUrl}/cards/${card.id}`;
const cardUrl = '<' + url + '|' + card.name + '>'; const cardUrl = `<${url}|${card.name}>`;
console.log(cardUrl);
return cardUrl; return cardUrl;
} }
module.exports = { module.exports = {
sendSlackMessage, sendSlackMessage,
buildCardUrl buildCardUrl,
}; };

Loading…
Cancel
Save