fix: Fix attachment headers

Closes #231

.github/workflows/build-and-push-docker-image.yml

@@ -0,0 +1,42 @@
+name: Build and push Docker image
+
+on:
+  release:
+    types: [created]
+
+jobs:
+  build-and-push-docker-image:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v1
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v1
+
+      - name: Login to GitHub Container Registry
+        uses: docker/login-action@v1
+        with:
+          registry: ghcr.io
+          username: ${{ github.repository_owner }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Set version
+        uses: actions/github-script@v6
+        id: set-version
+        with:
+          result-encoding: string
+          script: return context.payload.release.tag_name.replace('v', '')
+
+      - name: Build and push
+        uses: docker/build-push-action@v2
+        with:
+          context: .
+          platforms: linux/amd64,linux/arm64,linux/arm/v7
+          push: true
+          tags: |
+            ghcr.io/plankanban/planka:latest
+            ghcr.io/plankanban/planka:${{ steps.set-version.outputs.result }}

docker-compose.yml

@@ -2,7 +2,7 @@ version: '3'
 
 services:
   planka:
-    image: meltyshev/planka:latest
+    image: ghcr.io/plankanban/planka:latest
     command: >
       bash -c
         "for i in `seq 1 30`; do

server/api/controllers/attachments/download-thumbnail.js

@@ -61,7 +61,9 @@ module.exports = {
       throw Errors.ATTACHMENT_NOT_FOUND;
     }
 
-    this.res.setHeader('Content-Disposition', `inline; ${inputs.filename}`);
+    this.res.type(attachment.filename);
+    this.res.set('Cache-Control', 'private, max-age=900'); // TODO: move to config
+
     return exits.success(fs.createReadStream(filePath));
   },
 };

server/api/controllers/attachments/download.js

@@ -14,10 +14,6 @@ module.exports = {
       regex: /^[0-9]+$/,
       required: true,
     },
-    filename: {
-      type: 'string',
-      required: true,
-    },
   },
 
   exits: {
@@ -56,14 +52,12 @@ module.exports = {
       throw Errors.ATTACHMENT_NOT_FOUND;
     }
 
-    let contentDisposition;
+    this.res.type(attachment.filename);
-    if (attachment.isImage || path.extname(attachment.filename) === '.pdf') {
+    if (!attachment.isImage && path.extname(attachment.filename) !== '.pdf') {
-      contentDisposition = 'inline';
+      this.res.set('Content-Disposition', 'attachment');
-    } else {
-      contentDisposition = `attachment; ${inputs.filename}`;
     }
+    this.res.set('Cache-Control', 'private, max-age=900'); // TODO: move to config
 
-    this.res.setHeader('Content-Disposition', contentDisposition);
     return exits.success(fs.createReadStream(filePath));
   },
 };