Commit Graph

88 Commits (fe376b10c15c7825235aba64b42209de8d0c8ce5)

Author SHA1 Message Date
Maksim Eltyshev ca6a1a14f5 fix: Fix nullable boolean inputs 2 years ago
Maksim Eltyshev 51d05f3cd3 fix: Include due date when importing from Trello
Closes #598
2 years ago
Maksim Eltyshev b8d262f745 feat: Add ability to enforce SSO
Closes #543, closes #545
2 years ago
Maksim Eltyshev 634d6ceab1 feat: Add ability to map OIDC attributes and ignore username
Closes #554
2 years ago
Maksim Eltyshev 28c3f28e01 fix: Add issuer to OIDC callback parameters
Closes #562
2 years ago
Maksim Eltyshev 6dc9e4ed99 fix: Disable role change when OIDC roles are not ignored 2 years ago
Balthasar Hofer d4b64b90fc
feat: Add ability to ignore roles when logging in with SSO (#534)
Closes #533
2 years ago
Maksim Eltyshev 40c04c35ff ref: Refactoring 2 years ago
Lorenz Brun 743f2956c8
feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2 years ago
Maksim Eltyshev 6662b0a717 fix: Fix order of checks when logging in 2 years ago
Maksim Eltyshev 8e0c60f5be fix: OIDC finalization and refactoring 2 years ago
Maksim Eltyshev 91bc889fed feat: Use environment variables for default admin configuration 2 years ago
gorrilla10101 107cb85ba2
feat: OIDC with PKCE flow (#491) 2 years ago
Maksim Eltyshev d386c82973 fix: Fix saving milliseconds for timestamps 3 years ago
Maksim Eltyshev d0a2734161 fix: Rename timer to stopwatch
Closes #392
3 years ago
Maksim Eltyshev 8012f5319c fix: Fix import from Trello
Closes #397
3 years ago
Maksim Eltyshev 0f50dbde92 fix: Preserve orientation of images
Closes #384
3 years ago
Maksim Eltyshev aa69bb8d1e feat: Labels reordering
Closes #289
3 years ago
Maksim Eltyshev b58b91baa1 ref: Little refactoring 3 years ago
Maksim Eltyshev 6021d67a00 fix: Subscribe only when needed 3 years ago
Maksim Eltyshev 7e07a75124 fix: Improve quality of resized images 3 years ago
Maksim Eltyshev 6ffa817b53 ref: Remove board types, refactoring 3 years ago
Maksim Eltyshev 2bc82d557a fix: Fix image size for animated attachments 3 years ago
Maksim Eltyshev 0a5210dd21 feat: Preserve original format of images, change interpolation kernel
Closes #349
3 years ago
Christoph Enne 738ed19e7f
feat: Trello board JSON import (#352)
Closes #27, closes #105
3 years ago
Maksim Eltyshev c181731870 fix: Fix card repositioning
Closes #340
3 years ago
Maksim Eltyshev 172f4fcf34 fix: Fix missing board memberships loading 3 years ago
Maksim Eltyshev 9f16881965 fix: Socket bug fixes and improvements 3 years ago
Maksim Eltyshev 8109936ce2 feat: Invalidate access token on logout 3 years ago
Maksim Eltyshev 3df07c10fa fix: Use password strength estimator
Closes #294
3 years ago
Maksim Eltyshev 5c91bddfe7 feat: Stronger password policy 3 years ago
Maksim Eltyshev 5b64d465e2 fix: Use move-file instead of rename 3 years ago
Maksim Eltyshev cece2254d7 fix: Change mechanics of file uploading 3 years ago
Steven Correia 6429e22d59
feat: Modify logger to log to file that supports fail2ban (#284) 3 years ago
Maksim Eltyshev 51fa7df69c feat: Permissions for board members
Closes #262
3 years ago
Maksim Eltyshev eea94e0ee2 ref: Little change for consistency 3 years ago
SimonTagne 7786533a90
feat: Improve security of access tokens (#279)
Closes #275
3 years ago
Maksim Eltyshev 3714bbc06f ref: Refactoring 3 years ago
Maksim Eltyshev ac1df5201d fix: Fix path traversal vulnerability 3 years ago
Maksim Eltyshev 34db8947b6 feat: Toggle actions details, little redesign 3 years ago
Maksim Eltyshev a148a3aae5 feat: Add language selector
Closes #212
3 years ago
Maksim Eltyshev ad67b9ba24 feat: Add tasks reordering
Closes #50, closes #232
3 years ago
Maksim Eltyshev 3b3bff1b6b fix: Allow to use endpoints via http 4 years ago
Maksim Eltyshev 6268ced4cb ref: Collapse image data into one column 4 years ago
Maksim Eltyshev 86e4864d1b feat: Add gallery for attachments 4 years ago
Maksim Eltyshev b0b6587eee fix: Fix attachment headers
Closes #231
4 years ago
Maksim Eltyshev 445b0fc682 fix: Change way to fix application crash when deleting project 4 years ago
Maksim Eltyshev 2e045217ec fix: Fix application crash after deleting project 4 years ago
Maksim Eltyshev 36e4bef21b feat: Remove attachments from public access
Closes #219
4 years ago
Maksim Eltyshev 486e663a3d feat: Store accessToken in cookies instead of localStorage 4 years ago