Commit Graph

38 Commits (f1c72df8b6fca62dffb22a95dbd97d6add2d75d9)

Author SHA1 Message Date
Maksim Eltyshev 40c04c35ff ref: Refactoring 2 years ago
Lorenz Brun 743f2956c8
feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2 years ago
Maksim Eltyshev 8e0c60f5be fix: OIDC finalization and refactoring 2 years ago
Maksim Eltyshev 875895b331 fix: Fix starting without OIDC environment variables
Closes #503
2 years ago
Maksim Eltyshev 91bc889fed feat: Use environment variables for default admin configuration 2 years ago
gorrilla10101 107cb85ba2
feat: OIDC with PKCE flow (#491) 2 years ago
Maksim Eltyshev d386c82973 fix: Fix saving milliseconds for timestamps 3 years ago
Maksim Eltyshev 6ffa817b53 ref: Remove board types, refactoring 3 years ago
Maksim Eltyshev 0a5210dd21 feat: Preserve original format of images, change interpolation kernel
Closes #349
3 years ago
Jacques Lorentz b08e731419
fix: Front-end base url with path (#303)
Closes #43, closes #111, closes #272
3 years ago
Maksim Eltyshev 8109936ce2 feat: Invalidate access token on logout 3 years ago
Steven Correia 543a992d98
fix: Fix proxy forwarding (#295) 3 years ago
Maksim Eltyshev 07867fc0b2 fix: Use custom logger only for production 3 years ago
Steven Correia 6429e22d59
feat: Modify logger to log to file that supports fail2ban (#284) 3 years ago
Maksim Eltyshev 51fa7df69c feat: Permissions for board members
Closes #262
3 years ago
Maksim Eltyshev d38e555293 fix: Provide default value for token expiration 3 years ago
SimonTagne 7786533a90
feat: Improve security of access tokens (#279)
Closes #275
3 years ago
Maksim Eltyshev ac1df5201d fix: Fix path traversal vulnerability 3 years ago
Maksim Eltyshev e7495e0067 fix: Fix routes again 4 years ago
Maksim Eltyshev b8c065e0c8 fix: Fix routes 4 years ago
Maksim Eltyshev 86e4864d1b feat: Add gallery for attachments 4 years ago
Maksim Eltyshev 36e4bef21b feat: Remove attachments from public access
Closes #219
4 years ago
Maksim Eltyshev 486e663a3d feat: Store accessToken in cookies instead of localStorage 4 years ago
dbrennand 729e5dac5e
Make trustProxy configurable via environment variable 4 years ago
Maksim Eltyshev b39119ace4 Project managers, board members, auto-update after reconnection, refactoring 5 years ago
Maksim Eltyshev 08aef7c052 Change database adapter to support the new Node. Closes #32 5 years ago
Maksim Eltyshev 767d39586c Add test libs, update dependencies 5 years ago
Maksim Eltyshev c6ee7d54bb Prepare for collection board type, refactoring, update dependencies 5 years ago
Maksim Eltyshev 2f7a244807 Add project backgrounds 6 years ago
Maksim Eltyshev f743f4ea8b Add file attachments 6 years ago
Maksim Eltyshev af00e3e191 Add username to user 6 years ago
Maksim Eltyshev 9c7c96a780 Move from prettier-eslint to eslint-plugin-prettier, update dependencies 6 years ago
Maksim Eltyshev a11f6260c0 Code formatting with prettier, change eslint config for the server 6 years ago
Maksim Eltyshev 2566ff376e Add email and password change functionality for a current user, remove deep compare hooks 6 years ago
Maksim Eltyshev e8139b29d5 Change id generation algorithm, display notifications total on the main page 6 years ago
Maksim Eltyshev 64acf0ac56 Add secret key to environment variables, update readme 6 years ago
Maksim Eltyshev d24c9a7968 Docker, update readme, update dependencies 6 years ago
Maksim Eltyshev 5ffef61fe7 Initial commit 6 years ago