Commit Graph

47 Commits (f1c72df8b6fca62dffb22a95dbd97d6add2d75d9)

Author SHA1 Message Date
Maksim Eltyshev 5056d38848 fix: Fix logging out with invalid token 2 years ago
Maksim Eltyshev 7ef457157e fix: Fallback to query if there is no fragment 2 years ago
Maksim Eltyshev 40c04c35ff ref: Refactoring 2 years ago
Lorenz Brun 743f2956c8
feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2 years ago
Maksim Eltyshev 8e0c60f5be fix: OIDC finalization and refactoring 2 years ago
gorrilla10101 107cb85ba2
feat: OIDC with PKCE flow (#491) 2 years ago
Maksim Eltyshev 2d7812a679 fix: Use creation timestamp instead of id for ordering
Closes #465
3 years ago
Maksim Eltyshev aa69bb8d1e feat: Labels reordering
Closes #289
3 years ago
RAR ed89fe5351
feat: Open card once created with Ctrl+Enter (#373) 3 years ago
Maksim Eltyshev 6021d67a00 fix: Subscribe only when needed 3 years ago
Maksim Eltyshev 6ffa817b53 ref: Remove board types, refactoring 3 years ago
Maksim Eltyshev 0a5210dd21 feat: Preserve original format of images, change interpolation kernel
Closes #349
3 years ago
Christoph Enne 738ed19e7f
feat: Trello board JSON import (#352)
Closes #27, closes #105
3 years ago
Maksim Eltyshev a858419f3c fix: Fix router synchronization with redux store 3 years ago
Maksim Eltyshev b0d23373c0 chore: Update dependencies 3 years ago
Maksim Eltyshev 8109936ce2 feat: Invalidate access token on logout 3 years ago
Maksim Eltyshev 21ef850913 fix: Fix missed function name 3 years ago
Maksim Eltyshev 51fa7df69c feat: Permissions for board members
Closes #262
3 years ago
Maksim Eltyshev eea94e0ee2 ref: Little change for consistency 3 years ago
SimonTagne 7786533a90
feat: Improve security of access tokens (#279)
Closes #275
3 years ago
Maksim Eltyshev 3714bbc06f ref: Refactoring 3 years ago
Maksim Eltyshev 34db8947b6 feat: Toggle actions details, little redesign 3 years ago
Maksim Eltyshev a148a3aae5 feat: Add language selector
Closes #212
3 years ago
Maksim Eltyshev ad67b9ba24 feat: Add tasks reordering
Closes #50, closes #232
3 years ago
Maksim Eltyshev c9b23652d1 feat: Add ability to edit users
Closes #60
4 years ago
Maksim Eltyshev 486e663a3d feat: Store accessToken in cookies instead of localStorage 4 years ago
Maksim Eltyshev 4371e16c8d feat: Fallback to English if translation is missing
Closes #175
4 years ago
Maksim Eltyshev f539e7b76d Fix language loading. Closes #207 4 years ago
Maksim Eltyshev b39119ace4 Project managers, board members, auto-update after reconnection, refactoring 5 years ago
Maksim Eltyshev c6ee7d54bb Prepare for collection board type, refactoring, update dependencies 5 years ago
Maksim Eltyshev ff95a12578 Background gradients, migrate from CSS to SCSS, remove !important 6 years ago
Maksim Eltyshev 2f7a244807 Add project backgrounds 6 years ago
Maksim Eltyshev c5b44598f9 Fix members and labels creation when transfer card to another board 6 years ago
Maksim Eltyshev 35f9631326 Preserve members and labels when transfer card to another board 6 years ago
Maksim Eltyshev cbc942e306 Move cards between boards and projects 6 years ago
Maksim Eltyshev 712567ac57 Change user size on card, save card description on click outside, prevent list deletion if any filter is active 6 years ago
Maksim Eltyshev ce39b584ca Fix attachment duplication on add 6 years ago
Maksim Eltyshev f743f4ea8b Add file attachments 6 years ago
Maksim Eltyshev af00e3e191 Add username to user 6 years ago
Maksim Eltyshev d1b74f9d11 Update dependencies 6 years ago
Maksim Eltyshev 9c7c96a780 Move from prettier-eslint to eslint-plugin-prettier, update dependencies 6 years ago
Maksim Eltyshev a11f6260c0 Code formatting with prettier, change eslint config for the server 6 years ago
Maksim Eltyshev 2566ff376e Add email and password change functionality for a current user, remove deep compare hooks 6 years ago
Maksim Eltyshev e8139b29d5 Change id generation algorithm, display notifications total on the main page 6 years ago
Maksim Eltyshev 51013b6a32 Rename deadline to due date, update dependencies 6 years ago
Maksim Eltyshev 6eb431f721 Mute socket messages in production, fix max-len, update dependencies 6 years ago
Maksim Eltyshev 5ffef61fe7 Initial commit 6 years ago