Commit Graph

63 Commits (b46fb43e6fe69c860849eb5688de238d88171358)

Author SHA1 Message Date
Matthieu Bollot 2f3dfe775e
feat: Slack bot notifications (#676) 2 years ago
Matthieu Bollot 6cd9da844f
feat: Add ability to duplicate card (#668) 2 years ago
Edouard 9f0fce098e
feat: SMTP integration and email notifications (#631) 2 years ago
Maksim Eltyshev 51d05f3cd3 fix: Include due date when importing from Trello
Closes #598
2 years ago
Maksim Eltyshev 634d6ceab1 feat: Add ability to map OIDC attributes and ignore username
Closes #554
2 years ago
Maksim Eltyshev 28c3f28e01 fix: Add issuer to OIDC callback parameters
Closes #562
2 years ago
Maksim Eltyshev 6dc9e4ed99 fix: Disable role change when OIDC roles are not ignored 2 years ago
Balthasar Hofer d4b64b90fc
feat: Add ability to ignore roles when logging in with SSO (#534)
Closes #533
2 years ago
Maksim Eltyshev 40c04c35ff ref: Refactoring 2 years ago
Lorenz Brun 743f2956c8
feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2 years ago
Maksim Eltyshev 8e0c60f5be fix: OIDC finalization and refactoring 2 years ago
Maksim Eltyshev d386c82973 fix: Fix saving milliseconds for timestamps 3 years ago
Maksim Eltyshev 8012f5319c fix: Fix import from Trello
Closes #397
3 years ago
Maksim Eltyshev 0f50dbde92 fix: Preserve orientation of images
Closes #384
3 years ago
Maksim Eltyshev aa69bb8d1e feat: Labels reordering
Closes #289
3 years ago
Maksim Eltyshev b58b91baa1 ref: Little refactoring 3 years ago
Maksim Eltyshev 7e07a75124 fix: Improve quality of resized images 3 years ago
Maksim Eltyshev 6ffa817b53 ref: Remove board types, refactoring 3 years ago
Maksim Eltyshev 2bc82d557a fix: Fix image size for animated attachments 3 years ago
Maksim Eltyshev 0a5210dd21 feat: Preserve original format of images, change interpolation kernel
Closes #349
3 years ago
Christoph Enne 738ed19e7f
feat: Trello board JSON import (#352)
Closes #27, closes #105
3 years ago
Maksim Eltyshev c181731870 fix: Fix card repositioning
Closes #340
3 years ago
Maksim Eltyshev 9f16881965 fix: Socket bug fixes and improvements 3 years ago
Maksim Eltyshev 8109936ce2 feat: Invalidate access token on logout 3 years ago
Maksim Eltyshev 5b64d465e2 fix: Use move-file instead of rename 3 years ago
Maksim Eltyshev cece2254d7 fix: Change mechanics of file uploading 3 years ago
Maksim Eltyshev 51fa7df69c feat: Permissions for board members
Closes #262
3 years ago
SimonTagne 7786533a90
feat: Improve security of access tokens (#279)
Closes #275
3 years ago
Maksim Eltyshev 3714bbc06f ref: Refactoring 3 years ago
Maksim Eltyshev 34db8947b6 feat: Toggle actions details, little redesign 3 years ago
Maksim Eltyshev ad67b9ba24 feat: Add tasks reordering
Closes #50, closes #232
3 years ago
Maksim Eltyshev 6268ced4cb ref: Collapse image data into one column 4 years ago
Maksim Eltyshev 445b0fc682 fix: Change way to fix application crash when deleting project 4 years ago
Maksim Eltyshev 2e045217ec fix: Fix application crash after deleting project 4 years ago
Maksim Eltyshev 1a5c0f53f8 Fix board deletion, update dependencies. Closes #146 4 years ago
Maksim Eltyshev b39119ace4 Project managers, board members, auto-update after reconnection, refactoring 5 years ago
Maksim Eltyshev fb42ed460e Set best image quality for all uploads. Closes #114 5 years ago
Maksim Eltyshev f718464940 Fix variables in update-card, update dependencies. Closes #85 5 years ago
Maksim Eltyshev 3cdb614b57 Fix loading deleted users on actions fetch. Closes #62 5 years ago
Maksim Eltyshev c6ee7d54bb Prepare for collection board type, refactoring, update dependencies 5 years ago
Maksim Eltyshev d22580cec0 Fix removing background 6 years ago
Maksim Eltyshev 99d9ab4a9e Add validation to background field 6 years ago
Maksim Eltyshev ff95a12578 Background gradients, migrate from CSS to SCSS, remove !important 6 years ago
Maksim Eltyshev 2f7a244807 Add project backgrounds 6 years ago
Maksim Eltyshev 746e2fe790 Make columns itself scrollable, fix action creation when moving card, little refactoring 6 years ago
Maksim Eltyshev c5b44598f9 Fix members and labels creation when transfer card to another board 6 years ago
Maksim Eltyshev 35f9631326 Preserve members and labels when transfer card to another board 6 years ago
Maksim Eltyshev f4c8bc6ab9 Remove members and labels when transfer card to another board 6 years ago
Maksim Eltyshev cbc942e306 Move cards between boards and projects 6 years ago
Maksim Eltyshev 246eb17249 Add dropzone for attachment, paste attachment from clipboard 6 years ago