Commit Graph

22 Commits (9699fbe76a4cebe1820cdf45319c9d4572f94dac)

Author SHA1 Message Date
Maksim Eltyshev 9699fbe76a feat: Additional httpOnly token for enhanced security in browsers 1 year ago
Maksim Eltyshev aff853c602 ref: Refactoring, fix linting 1 year ago
aleb_the_flash ad2966c5d6
feat: Improve OIDC support for strict providers (#824) 1 year ago
Maksim Eltyshev c065566c15 feat: Webhooks configuration, all events support, refactoring 2 years ago
HannesOberreiter 3779bdb053
feat: Events via webhook (#771)
Closes #215, closes #656
2 years ago
Maksim Eltyshev 634d6ceab1 feat: Add ability to map OIDC attributes and ignore username
Closes #554
2 years ago
Maksim Eltyshev 28c3f28e01 fix: Add issuer to OIDC callback parameters
Closes #562
2 years ago
Maksim Eltyshev 6dc9e4ed99 fix: Disable role change when OIDC roles are not ignored 2 years ago
Balthasar Hofer d4b64b90fc
feat: Add ability to ignore roles when logging in with SSO (#534)
Closes #533
2 years ago
Maksim Eltyshev 40c04c35ff ref: Refactoring 2 years ago
Lorenz Brun 743f2956c8
feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2 years ago
Maksim Eltyshev 8e0c60f5be fix: OIDC finalization and refactoring 2 years ago
Maksim Eltyshev d386c82973 fix: Fix saving milliseconds for timestamps 3 years ago
Maksim Eltyshev 0f50dbde92 fix: Preserve orientation of images
Closes #384
3 years ago
Maksim Eltyshev b58b91baa1 ref: Little refactoring 3 years ago
Maksim Eltyshev 7e07a75124 fix: Improve quality of resized images 3 years ago
Maksim Eltyshev 6ffa817b53 ref: Remove board types, refactoring 3 years ago
Maksim Eltyshev 0a5210dd21 feat: Preserve original format of images, change interpolation kernel
Closes #349
3 years ago
Maksim Eltyshev 9f16881965 fix: Socket bug fixes and improvements 3 years ago
Maksim Eltyshev cece2254d7 fix: Change mechanics of file uploading 3 years ago
SimonTagne 7786533a90
feat: Improve security of access tokens (#279)
Closes #275
3 years ago
Maksim Eltyshev b39119ace4 Project managers, board members, auto-update after reconnection, refactoring 5 years ago